Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent direction inputs expected for SHEncoding.forward() when implementation = torch/tcnn #3463

Open
wengflow opened this issue Oct 4, 2024 · 0 comments

Comments

@wengflow
Copy link

wengflow commented Oct 4, 2024

When implementation = torch, the in_tensor input of SHEncoding.forward() is expected to be unit vectors normalized between [-1, 1], as expected by components_from_spherical_harmonics(). However, when implementation = tcnn, in_tensor is expected to be vectors normalized between [0, 1], as expected by tcnn.Encoding. This inconsistency also propagates to NerfactoField and GenerfactoField.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant