Skip to content

Latest commit

 

History

History
142 lines (107 loc) · 7.03 KB

CONTRIBUTING.md

File metadata and controls

142 lines (107 loc) · 7.03 KB
Raw

Contributing

We are open to, and grateful for, any contributions made by you. By contributing to DraftJS Plugins, you agree to abide by the code of conduct.

Reporting Issues and Asking Questions

Before opening an issue, please search the issue tracker to make sure your issue hasn’t already been reported.

Development

You must have Node.js v5 or later installed to develop DraftJS plugins. We mostly use the docs to hack & prototype new features. Get it up & running with:

npm install --global yarn
yarn install
cd docs
yarn install
npm start

Linting

We follow the Airbnb JavaScript Styleguide with a few exeptions. Checkout the .eslintrc and .flowconfig to see the rules. With running this command you can check if your code-changes comply to the style we chose:

npm run lint

Do not hesitate to propose changes to the style. We are open to these as well.

Testing

Please help us to improve the test-suite, by adding & updating tests together with your submission. While it's not mandatory it makes our lives way easier to review your changes and keep up the quality of the software.

Run all the tests via:

npm test

Changelog

We keep a changelog for each released package. Please help us by adding your changes to the changelog. We follow the recommendations of keepachangelog.com.

Documentation

Independent improvements to the documentation are very welcome. I (Nik) would even argue that most of them are even more valuable than changes to the libraries themselves.

We are also happy about updates to the documentation in combination with changes.

Using your own fork in your own development

Because of the structure of this repository you can not just use your own fork of draft-js-plugins in your own development projects. There are a few problems; first NPM doesn't allow referencing sub directories. So "draft-js-plugins-editor": "<your github username>/draft-js-plugins-editor" does not work. And secondly by specifying "draft-js-plugins": "<your github username>/draft-js-plugins" NPM does not get the sources for the different sub projects (I "Mark" don't know why). Thankfully Yarn does do this as expected. So to get your own fork working you need to follow the folling steps:

  1. Add "draft-js-plugins": "<your github username>/draft-js-plugins" to your package files.

  2. Install Yarn npm install --global yarn and install node modules yarn install

  3. Reference the needed sub packages in your code f.ex. the plugin editor import PluginEditor from 'draft-js-plugins-editor';

  4. When using Webpack you need to tell it how to compile the draft-js-plugins code, you do that by adding an additional loader like this:

module: {
  loaders: [{
    test: /\.js$/,
    loaders: 'babel-loader',
    include: [
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-plugins-editor', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-hashtag-plugin', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-linkify-plugin', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-mention-plugin', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-sticker-plugin', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-undo-plugin', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-emoji-plugin', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-drag-n-drop-plugin', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-drag-n-drop-upload-plugin', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-counter-plugin', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-focus-plugin', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-alignment-plugin', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-image-plugin', 'src'),
      path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-resizeable-plugin', 'src')
    ]
  }]
}
  1. And you need to tell the compiler where to find the different draft-js-plugins modules
resolve: {
  alias: {
    'draft-js-plugins-editor': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-plugins-editor', 'src'),
    'draft-js-hashtag-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-hashtag-plugin', 'src'),
    'draft-js-linkify-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-linkify-plugin', 'src'),
    'draft-js-mention-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-mention-plugin', 'src'),
    'draft-js-sticker-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-sticker-plugin', 'src'),
    'draft-js-undo-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-undo-plugin', 'src'),
    'draft-js-emoji-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-emoji-plugin', 'src'),
    'draft-js-counter-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-counter-plugin', 'src'),
    'draft-js-drag-n-drop-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-drag-n-drop-plugin', 'src'),
    'draft-js-drag-n-drop-upload-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-drag-n-drop-upload-plugin', 'src'),
    'draft-js-focus-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-focus-plugin', 'src'),
    'draft-js-alignment-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-alignment-plugin', 'src'),
    'draft-js-image-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-image-plugin', 'src'),
    'draft-js-resizeable-plugin': path.join(__dirname, 'node_modules', 'draft-js-plugins', 'draft-js-resizeable-plugin', 'src')
  }
}

For your CSS loader in webpack, ensure you enable CSS modules:

{
  test: /\.css$/,
  loaders: [
    'style-loader', 'css-loader?modules'
  ]
}

You'll need to use Babel Stage-0 if you aren't already. First, install it:

yarn add babel-preset-stage-0

Then use it as a preset when loading your JS:

{
  test: /\.js$/,
  loader: 'babel-loader',
  query: {
    presets: ['es2015', 'react', 'stage-0'],
  },
}

Publishing Github Pages (for the core team)

Run ./scripts/publishGithubPages.sh

The build script renames the .babelrc files of all plugins to avoid issues with the build. In the future we might be able to remove this again.