fix: check all props in shouldComponentUpdate

neptunejs · Apr 24, 2017 · dacfde2 · dacfde2
1 parent 10e5ab1
commit dacfde2
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/Hierarchy.js b/src/Hierarchy.js
@@ -163,7 +163,16 @@ class Hierarchy extends Component {
     }
 
     shouldComponentUpdate(nextProps) {
-        return treeSelector(nextProps) !== this.computedTree;
+        return (
+            this.props.nodeRenderer !== nextProps.nodeRenderer ||
+            this.props.rootRenderer !== nextProps.rootRenderer ||
+            this.props.leafRenderer !== nextProps.leafRenderer ||
+            this.props.onNodeClick !== nextProps.onNodeClick ||
+            this.props.transition !== nextProps.transition ||
+            this.props.width !== nextProps.width ||
+            this.props.height !== nextProps.height ||
+            treeSelector(nextProps) !== this.computedTree
+        );
     }
 
     render() {