porch: git access parameters do not follow changes in the porch Repository object

[kispaljr]

I encountered the following issue that seems to be a bug in the git client handling in porch:

1. Repository.config.porch.kpt.dev object created with missing secretRef field
2. kpt alpha rpkg init ... command fails with message: Error: Internal error occurred: authentication required
3. Correct secretRef info is patched into the Repository (with kubectl apply)
4. kpt alpha rpkg init ... command fails with the same message: Error: Internal error occurred: authentication required
5. Repository object is deleted and the recreated with the same contents
6. kpt alpha rpkg init ... command succeeds

[kispaljr]

This seems to be a duplicate of kptdev/kpt#4088
Sorry.
Should I leave the issue open anyway, considering that eventually we want to track porch issues under Nephio, not under kpt?

[liamfallon]

I think we should probably move any issues that still exist (probably most of them) across to here. Maybe we can check with @johnbelamaric about what's the best thing to do.

[johnbelamaric]

Yeah, we should move them here. Moving issues from one org to a different org is not something that is natively supported by GitHub. But it looks like there are some workarounds in the comments here (I have not tried any of these): https://github.com/orgs/community/discussions/5766

[liamfallon]

Triaged

[kushnaidu]

I cannot reproduce the issue any more and won't create a PR for this issue.
My findings are as follows,

Repository created without secretref -

porchctl command throws error with auth failed -

Update repo and init again with porchctl -

The command succeeds without any issue.

Same tried with kpt alpha and without any issue -

As soon as we change the repository, we can see in the logs that porch can recognize the change and updates the cache.

Closing the ticket.