-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add K8S_CONTEXT label documentation #143
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for nephio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
**Kind Cluster** | ||
|
||
Log onto your VM and run the following command : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this always a VM and do we always need to log in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wording that was already present in the doc, and given that the heading of this section is "Kick Off an Installation on VM" I personally would leave the text as is
Co-authored-by: Liam Fallon <[email protected]>
@dkosteck I am rearranging the documents and I believe adding this text in https://github.com/nephio-project/docs/blob/main/content/en/docs/guides/install-guides/install-on-single-vm.md guide rather than in the index is better. I am thinking of removing the text from the index as it is repetitive. |
@arora-sagar That's fine, but in the interim I would say that the new variable and usage should still be documented here, and if it gets reshuffled by your PR then that's fine. Since nephio-project/test-infra#269 was merged though it seems this should be present in the current table and location, at least for the time being |
Okay then lets merge this and then I will add a PR on the top. |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CsatariGergely, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is contingent on, and related to nephio-project/test-infra#269 so will be submitted as a draft for the time being. Documenting the additional variable of K8S_CONTEXT introduced in the linked PR for deploying Nephio components on non-kind clusters.
Note also that in the "Real K8s Cluster" installation instructions the branch should be updated once nephio-project/test-infra#269 is merged and a new tag is available.
Closes nephio-project/nephio#577