Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add K8S_CONTEXT label documentation #143

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

dkosteck
Copy link
Contributor

@dkosteck dkosteck commented Jun 20, 2024

This is contingent on, and related to nephio-project/test-infra#269 so will be submitted as a draft for the time being. Documenting the additional variable of K8S_CONTEXT introduced in the linked PR for deploying Nephio components on non-kind clusters.

Note also that in the "Real K8s Cluster" installation instructions the branch should be updated once nephio-project/test-infra#269 is merged and a new tag is available.

Closes nephio-project/nephio#577

Copy link
Contributor

nephio-prow bot commented Jun 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 844ab7b
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/667d684e84ea9b000890596e
😎 Deploy Preview https://deploy-preview-143--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dkosteck dkosteck marked this pull request as ready for review June 26, 2024 19:22

**Kind Cluster**

Log onto your VM and run the following command :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always a VM and do we always need to log in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wording that was already present in the doc, and given that the heading of this section is "Kick Off an Installation on VM" I personally would leave the text as is

@arora-sagar
Copy link
Contributor

@dkosteck I am rearranging the documents and I believe adding this text in https://github.com/nephio-project/docs/blob/main/content/en/docs/guides/install-guides/install-on-single-vm.md guide rather than in the index is better.

I am thinking of removing the text from the index as it is repetitive.

@dkosteck
Copy link
Contributor Author

dkosteck commented Jun 27, 2024

@dkosteck I am rearranging the documents and I believe adding this text in https://github.com/nephio-project/docs/blob/main/content/en/docs/guides/install-guides/install-on-single-vm.md guide rather than in the index is better.

I am thinking of removing the text from the index as it is repetitive.

@arora-sagar That's fine, but in the interim I would say that the new variable and usage should still be documented here, and if it gets reshuffled by your PR then that's fine. Since nephio-project/test-infra#269 was merged though it seems this should be present in the current table and location, at least for the time being

@arora-sagar
Copy link
Contributor

@dkosteck I am rearranging the documents and I believe adding this text in https://github.com/nephio-project/docs/blob/main/content/en/docs/guides/install-guides/install-on-single-vm.md guide rather than in the index is better.
I am thinking of removing the text from the index as it is repetitive.

@arora-sagar That's fine, but in the interim I would say that the new variable and usage should still be documented here, and if it gets reshuffled by your PR then that's fine. Since nephio-project/test-infra#269 was merged though it seems this should be present in the current table and location, at least for the time being

Okay then lets merge this and then I will add a PR on the top.

@nephio-prow nephio-prow bot added the approved label Jun 27, 2024
@CsatariGergely
Copy link
Contributor

/approve

@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CsatariGergely, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CsatariGergely,liamfallon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit 83f2119 into nephio-project:main Jun 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy Nephio management cluster components on real k8s
4 participants