Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a render hook to Hugo generation #112

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

lapentad
Copy link
Contributor

@lapentad lapentad commented Feb 7, 2024

Based on this comment
This will make MD cross reference links work in both Github and Hugo rendered page.
And Images showing in both.

Note the link at the bottom
Before:
1
After:
2

Note the image:
3

Follwed this [comment](https://discourse.gohugo.io/t/how-can-i-convert-markdown-files-contains-relative-link-with-end-with-md-to-hugo-links/42087/2)
This will make MD cross reference links work in both Github and Hugo rendered page

Signed-off-by: lapentafd <[email protected]>
Signed-off-by: lapentafd <[email protected]>
@lapentad
Copy link
Contributor Author

lapentad commented Feb 7, 2024

@CsatariGergely

@efiacor
Copy link
Contributor

efiacor commented Feb 7, 2024

/assign @CsatariGergely

Copy link
Contributor

nephio-prow bot commented Feb 7, 2024

@efiacor: GitHub didn't allow me to assign the following users: CsatariGergely.

Note that only nephio-project members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @CsatariGergely

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Missed a replace for small images
@CsatariGergely
Copy link
Contributor

/assign @liamfallon
/assign @tliron

Please review this and get this merged.

Without this our links are broken in the docs site.

@gvbalaji
Copy link
Contributor

gvbalaji commented Feb 9, 2024

Thanks @lapentad and @CsatariGergely .
/approve
@radoslawc after we merge this, can we move the 2.0.0 tag to this commit.
/assign @radoslawc

@efiacor
Copy link
Contributor

efiacor commented Feb 9, 2024

/approve

Copy link
Contributor

nephio-prow bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, gvbalaji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Feb 9, 2024
@efiacor
Copy link
Contributor

efiacor commented Feb 12, 2024

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Feb 12, 2024
@nephio-prow nephio-prow bot merged commit 7e8aea0 into nephio-project:main Feb 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants