Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra migrations triggered when customizing BLOG_PLUGIN_TEMPLATE_FOLDERS #597

Closed
yakky opened this issue Jun 24, 2020 · 0 comments · Fixed by #600 or #601
Closed

Extra migrations triggered when customizing BLOG_PLUGIN_TEMPLATE_FOLDERS #597

yakky opened this issue Jun 24, 2020 · 0 comments · Fixed by #600 or #601
Milestone

Comments

@yakky
Copy link
Member

yakky commented Jun 24, 2020

Description

If first BLOG_PLUGIN_TEMPLATE_FOLDERS item is not plugins, a new migration is triggered due to hardcoded value in migrations

## Steps to reproduce

Steps

  1. Customize BLOG_PLUGIN_TEMPLATE_FOLDERS by setting to

    BLOG_PLUGIN_TEMPLATE_FOLDERS = (
        ('timeline', ('Vertical timeline')),  # reads from templates/djangocms_blog/vertical/
        ('masonry', ('Masonry style')),       # reads from templates/djangocms_blog/masonry/
    )
  2. Run ./manage.py makemigrations djangocms_blog

Versions

Any

Expected behaviour

No new migration is created

Actual behaviour

Migration created with:

Migrations for 'djangocms_blog':
  djangocms_blog/migrations/0040_auto_20200624_0649.py
    - Alter field template_folder on authorentriesplugin
    - Alter field template_folder on genericblogplugin
    - Alter field template_folder on latestpostsplugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant