Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline code highlighting has issues #17

Closed
echasnovski opened this issue Sep 26, 2022 · 2 comments · Fixed by #16
Closed

Inline code highlighting has issues #17

echasnovski opened this issue Sep 26, 2022 · 2 comments · Fixed by #16

Comments

@echasnovski
Copy link
Member

echasnovski commented Sep 26, 2022

There are multiple issues of recognizing inline code blocks. It usually works fine when backticks surround single word consisting from letters. Other than that, not so much.

Text:

`inline code with s`
`inline code with spaces`
`require('')`
`require('mod')`
`{}`

Current behavior with tree-sitter:
screenshot_2022-09-26_15:46:20

Current behavior without tree-sitter:
screenshot_2022-09-26_15:46:35

@justinmk
Copy link
Member

should be fixed by #16

@justinmk
Copy link
Member

justinmk commented Sep 28, 2022

should be fixed by #16

Here's the result with those changes:

(help_file
  (block
    (line
      (codespan
        (word)))
    (line
      (codespan
        (word)))
    (line
      (codespan
        (word)))
    (line
      (codespan
        (word)))
    (line
      (codespan
        (word)))))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants