feat(findNvim)!: rename paths:string[] => cmds:string[][] #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo
string[][]
orMap<string[]>
?NvimVersion.cmd
?Problem
Consumers like vscode-neovim/vscode-neovim#2287 can't send a full command which represents "nvim". It can only send a location (
arg0
) or directory.But such consumers want to invoke Nvim in WSL, which requires extra preamble before the
nvim.exe
part:https://github.com/vscode-neovim/vscode-neovim/blob/c3e8387a9e9f923ec39c28af6cb8985ca431e438/src/main_controller.ts#L181-L186
Solution
node-client doesn't need to know about WSL, it just needs to run what the consumer gives it. Currently the consumer can only send
arg0
, but we can fix that by allowing consumers to send[arg0, arg1, ...]
.findNvim
to acceptcmds: string[][]
, so that consumers can pass a command like:paths:string[]
option. It's redundant withcmds
.fix #430