feat: adds print button without manually detaching window #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JockeCK can't this be implemented without detaching/attaching the window? |
cristinecula
approved these changes
Oct 30, 2020
Not sure, the only way I found was by marking everything to not show up in the printscreen. Did not think that would be very practical. |
|
I will give it another go, see if I can do some css magic. |
|
@JockeCK if it performs well enough, you can merge it this way and we'll improve upon it later. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2020
# [3.3.0](v3.2.4...v3.3.0) (2020-10-30) ### Features * adds print button without manually detaching window ([#143](#143)) ([756be7e](756be7e))
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: #142