BUGFIX: Throw MappingException in loadMetaDataForClass #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no class schema can be found in `loadMetaDataForClass`, a Doctrine `MappingException` is now thrown. This makes our code work nicely with the change in doctrine/orm#7471 that otherwise leads to errors like this as of ORM 2.6.3: ``` FlowAnnotationDriver.php: No class schema found for "some-non-mapped-class". 89 …\FlowAnnotationDriver_Original::getClassSchema("some-non-mapped-class") 88 …\FlowAnnotationDriver_Original::loadMetadataForClass("some-non-mapped-class", Neos\Flow\Persistence\Doctrine\Mapping\ClassMetadata) ``` Fixes neos#1453
albe
approved these changes
Nov 21, 2018
There was a problem hiding this comment.
I was first wondering how rethrowing a different exception would fix anything, but after looking at the doctrine fix at https://github.com/doctrine/doctrine2/pull/7471/files#diff-be509179ad6fbf9ed8770312aa84b301R429 it makes sense! Thanks for digging into this so quickly @kdambekalns !
bwaidelich
approved these changes
Nov 21, 2018
Neos.Flow/Classes/Persistence/Doctrine/Mapping/Driver/FlowAnnotationDriver.php
Show resolved
Hide resolved
kitsunet
approved these changes
Nov 21, 2018
|
I assume 4.3 doesn't use ORM 2.6.x ? |
Correct. 2.5.x due to PHP 7.1 requirement |
|
Merged due to the urgency of the problem. We can refator the try catch block any time. |
|
Ok, I'll roll patch-level releases then… Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no class schema can be found in
loadMetaDataForClass, a DoctrineMappingExceptionis now thrown. This makes our code work nicely with thechange in doctrine/orm#7471 that otherwise
leads to errors like this as of ORM 2.6.3:
Fixes #1453