From c7c78d871d3f1c70041bb2308c028315a4a91007 Mon Sep 17 00:00:00 2001 From: Jenkins Date: Thu, 4 Jan 2024 16:19:30 +0000 Subject: [PATCH 01/29] TASK: Update references [skip ci] --- .../TheDefinitiveGuide/PartV/AnnotationReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/CommandReference.rst | 2 +- .../PartV/FluidAdaptorViewHelperReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TypeConverterReference.rst | 2 +- .../TheDefinitiveGuide/PartV/ValidatorReference.rst | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst index 15a17d944f..8bf8f01a96 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst @@ -3,7 +3,7 @@ Flow Annotation Reference ========================= -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`Flow Annotation Reference: After`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst index 9095ff61fd..c910372f58 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst @@ -19,7 +19,7 @@ commands that may be available, use:: ./flow help -The following reference was automatically generated from code on 2023-12-20 +The following reference was automatically generated from code on 2024-01-04 .. _`Flow Command Reference: NEOS.FLOW`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst index 8a8e741a7b..f91410d364 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst @@ -3,7 +3,7 @@ FluidAdaptor ViewHelper Reference ================================= -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`FluidAdaptor ViewHelper Reference: f:debug`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst index 1af0277321..9428955593 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst @@ -3,7 +3,7 @@ Flow Signals Reference ====================== -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`Flow Signals Reference: AbstractAdvice (``Neos\Flow\Aop\Advice\AbstractAdvice``)`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst index 7e22f05486..e3244d3262 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst @@ -3,7 +3,7 @@ TYPO3 Fluid ViewHelper Reference ================================ -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`TYPO3 Fluid ViewHelper Reference: f:alias`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst index 49a70c300f..561cfa0560 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst @@ -3,7 +3,7 @@ Flow TypeConverter Reference ============================ -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`Flow TypeConverter Reference: ArrayConverter`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst index 3df5d44d90..f59006bc39 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst @@ -3,7 +3,7 @@ Flow Validator Reference ======================== -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`Flow Validator Reference: AggregateBoundaryValidator`: From de3961a5f14a26bfbd8cca29af8c1751629e754b Mon Sep 17 00:00:00 2001 From: Jenkins Date: Thu, 4 Jan 2024 16:21:23 +0000 Subject: [PATCH 02/29] TASK: Update references [skip ci] --- .../TheDefinitiveGuide/PartV/AnnotationReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/CommandReference.rst | 2 +- .../PartV/FluidAdaptorViewHelperReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TypeConverterReference.rst | 2 +- .../TheDefinitiveGuide/PartV/ValidatorReference.rst | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst index 15a17d944f..8bf8f01a96 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst @@ -3,7 +3,7 @@ Flow Annotation Reference ========================= -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`Flow Annotation Reference: After`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst index 9095ff61fd..c910372f58 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst @@ -19,7 +19,7 @@ commands that may be available, use:: ./flow help -The following reference was automatically generated from code on 2023-12-20 +The following reference was automatically generated from code on 2024-01-04 .. _`Flow Command Reference: NEOS.FLOW`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst index 8a8e741a7b..f91410d364 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst @@ -3,7 +3,7 @@ FluidAdaptor ViewHelper Reference ================================= -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`FluidAdaptor ViewHelper Reference: f:debug`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst index 1af0277321..9428955593 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst @@ -3,7 +3,7 @@ Flow Signals Reference ====================== -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`Flow Signals Reference: AbstractAdvice (``Neos\Flow\Aop\Advice\AbstractAdvice``)`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst index 7e22f05486..e3244d3262 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst @@ -3,7 +3,7 @@ TYPO3 Fluid ViewHelper Reference ================================ -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`TYPO3 Fluid ViewHelper Reference: f:alias`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst index 49a70c300f..561cfa0560 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst @@ -3,7 +3,7 @@ Flow TypeConverter Reference ============================ -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`Flow TypeConverter Reference: ArrayConverter`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst index 3df5d44d90..f59006bc39 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst @@ -3,7 +3,7 @@ Flow Validator Reference ======================== -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`Flow Validator Reference: AggregateBoundaryValidator`: From 1106fb5eae320c8aa866ca76fa6bcf4773d6ab39 Mon Sep 17 00:00:00 2001 From: Jenkins Date: Thu, 4 Jan 2024 16:22:06 +0000 Subject: [PATCH 03/29] TASK: Update references [skip ci] --- .../TheDefinitiveGuide/PartV/AnnotationReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/CommandReference.rst | 2 +- .../PartV/FluidAdaptorViewHelperReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TypeConverterReference.rst | 2 +- .../TheDefinitiveGuide/PartV/ValidatorReference.rst | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst index 15a17d944f..8bf8f01a96 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst @@ -3,7 +3,7 @@ Flow Annotation Reference ========================= -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`Flow Annotation Reference: After`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst index 9095ff61fd..c910372f58 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst @@ -19,7 +19,7 @@ commands that may be available, use:: ./flow help -The following reference was automatically generated from code on 2023-12-20 +The following reference was automatically generated from code on 2024-01-04 .. _`Flow Command Reference: NEOS.FLOW`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst index 8a8e741a7b..f91410d364 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst @@ -3,7 +3,7 @@ FluidAdaptor ViewHelper Reference ================================= -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`FluidAdaptor ViewHelper Reference: f:debug`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst index 1af0277321..9428955593 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst @@ -3,7 +3,7 @@ Flow Signals Reference ====================== -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`Flow Signals Reference: AbstractAdvice (``Neos\Flow\Aop\Advice\AbstractAdvice``)`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst index 7e22f05486..e3244d3262 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst @@ -3,7 +3,7 @@ TYPO3 Fluid ViewHelper Reference ================================ -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`TYPO3 Fluid ViewHelper Reference: f:alias`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst index 49a70c300f..561cfa0560 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst @@ -3,7 +3,7 @@ Flow TypeConverter Reference ============================ -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`Flow TypeConverter Reference: ArrayConverter`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst index 3df5d44d90..f59006bc39 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst @@ -3,7 +3,7 @@ Flow Validator Reference ======================== -This reference was automatically generated from code on 2023-12-20 +This reference was automatically generated from code on 2024-01-04 .. _`Flow Validator Reference: AggregateBoundaryValidator`: From 605cea5b302bce68ba4efc8e311acb44ff10c485 Mon Sep 17 00:00:00 2001 From: Bastian Waidelich Date: Thu, 18 Jan 2024 16:54:16 +0100 Subject: [PATCH 04/29] BUGFIX: Fix documentation of `maximumThrowableDump` defaults Related: #3158 --- Neos.Flow/Configuration/Settings.Log.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Neos.Flow/Configuration/Settings.Log.yaml b/Neos.Flow/Configuration/Settings.Log.yaml index 4874d7e10c..ae81f146c0 100644 --- a/Neos.Flow/Configuration/Settings.Log.yaml +++ b/Neos.Flow/Configuration/Settings.Log.yaml @@ -58,7 +58,7 @@ Neos: optionsByImplementation: 'Neos\Flow\Log\ThrowableStorage\FileStorage': storagePath: '%FLOW_PATH_DATA%Logs/Exceptions' - # The maximum age of throwable dump in seconds, 0 to disable cleaning based on age, default 30 days + # The maximum age of throwable dump in seconds, 0 to disable cleaning based on age maximumThrowableDumpAge: 0 - # The maximum number of throwable dumps to store, 0 to disable cleaning based on count, default 10.000 + # The maximum number of throwable dumps to store, 0 to disable cleaning based on count maximumThrowableDumpCount: 0 From b4ed91a119a52a7bdc633681b1069cdc061cfd8b Mon Sep 17 00:00:00 2001 From: Jenkins Date: Thu, 18 Jan 2024 16:28:01 +0000 Subject: [PATCH 05/29] TASK: Update references [skip ci] --- .../TheDefinitiveGuide/PartV/AnnotationReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/CommandReference.rst | 2 +- .../PartV/FluidAdaptorViewHelperReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TypeConverterReference.rst | 2 +- .../TheDefinitiveGuide/PartV/ValidatorReference.rst | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst index 8bf8f01a96..78ad0076ae 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst @@ -3,7 +3,7 @@ Flow Annotation Reference ========================= -This reference was automatically generated from code on 2024-01-04 +This reference was automatically generated from code on 2024-01-18 .. _`Flow Annotation Reference: After`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst index 5b713559cf..fa23c64b0b 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst @@ -19,7 +19,7 @@ commands that may be available, use:: ./flow help -The following reference was automatically generated from code on 2024-01-04 +The following reference was automatically generated from code on 2024-01-18 .. _`Flow Command Reference: NEOS.FLOW`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst index f91410d364..581f4dbe7d 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst @@ -3,7 +3,7 @@ FluidAdaptor ViewHelper Reference ================================= -This reference was automatically generated from code on 2024-01-04 +This reference was automatically generated from code on 2024-01-18 .. _`FluidAdaptor ViewHelper Reference: f:debug`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst index 9b5205fd71..3e0f59c0c1 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst @@ -3,7 +3,7 @@ Flow Signals Reference ====================== -This reference was automatically generated from code on 2024-01-04 +This reference was automatically generated from code on 2024-01-18 .. _`Flow Signals Reference: AbstractAdvice (``Neos\Flow\Aop\Advice\AbstractAdvice``)`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst index e3244d3262..6171327bb3 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst @@ -3,7 +3,7 @@ TYPO3 Fluid ViewHelper Reference ================================ -This reference was automatically generated from code on 2024-01-04 +This reference was automatically generated from code on 2024-01-18 .. _`TYPO3 Fluid ViewHelper Reference: f:alias`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst index 561cfa0560..3d029b9f66 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst @@ -3,7 +3,7 @@ Flow TypeConverter Reference ============================ -This reference was automatically generated from code on 2024-01-04 +This reference was automatically generated from code on 2024-01-18 .. _`Flow TypeConverter Reference: ArrayConverter`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst index f59006bc39..c643dcb0c1 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst @@ -3,7 +3,7 @@ Flow Validator Reference ======================== -This reference was automatically generated from code on 2024-01-04 +This reference was automatically generated from code on 2024-01-18 .. _`Flow Validator Reference: AggregateBoundaryValidator`: From d2baec9eeeb351b028c39e404d4dbe015d866b8b Mon Sep 17 00:00:00 2001 From: lorenzulrich Date: Thu, 1 Feb 2024 13:54:32 +0100 Subject: [PATCH 06/29] TASK: Fix errors in Middleware code example --- Neos.Flow/Documentation/TheDefinitiveGuide/PartIII/Http.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartIII/Http.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartIII/Http.rst index 0fcf38d9ad..eb19c1c7fb 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartIII/Http.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartIII/Http.rst @@ -134,8 +134,8 @@ that defines the ``process($request, $next)`` method:: */ final class SomeMiddleware implements MiddlewareInterface { - public function process(ServerRequestInterface $request, RequestHandlerInterface $next): ResponseInterface; - $response = $next->handle($httpRequest); + public function process(ServerRequestInterface $request, RequestHandlerInterface $next): ResponseInterface { + $response = $next->handle($request); return $response->withAddedHeader('X-MyHeader', '123'); } } From a19e910ad85b5ba54f219c7c2bcc460b3507d247 Mon Sep 17 00:00:00 2001 From: Jenkins Date: Thu, 1 Feb 2024 15:42:00 +0000 Subject: [PATCH 07/29] TASK: Update references [skip ci] --- .../TheDefinitiveGuide/PartV/AnnotationReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/CommandReference.rst | 2 +- .../PartV/FluidAdaptorViewHelperReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TypeConverterReference.rst | 2 +- .../TheDefinitiveGuide/PartV/ValidatorReference.rst | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst index 78ad0076ae..d295e8e477 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst @@ -3,7 +3,7 @@ Flow Annotation Reference ========================= -This reference was automatically generated from code on 2024-01-18 +This reference was automatically generated from code on 2024-02-01 .. _`Flow Annotation Reference: After`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst index fa23c64b0b..e4de019682 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst @@ -19,7 +19,7 @@ commands that may be available, use:: ./flow help -The following reference was automatically generated from code on 2024-01-18 +The following reference was automatically generated from code on 2024-02-01 .. _`Flow Command Reference: NEOS.FLOW`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst index 581f4dbe7d..fa769a8476 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst @@ -3,7 +3,7 @@ FluidAdaptor ViewHelper Reference ================================= -This reference was automatically generated from code on 2024-01-18 +This reference was automatically generated from code on 2024-02-01 .. _`FluidAdaptor ViewHelper Reference: f:debug`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst index 3e0f59c0c1..c7f1db25f8 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst @@ -3,7 +3,7 @@ Flow Signals Reference ====================== -This reference was automatically generated from code on 2024-01-18 +This reference was automatically generated from code on 2024-02-01 .. _`Flow Signals Reference: AbstractAdvice (``Neos\Flow\Aop\Advice\AbstractAdvice``)`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst index 6171327bb3..b439807116 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst @@ -3,7 +3,7 @@ TYPO3 Fluid ViewHelper Reference ================================ -This reference was automatically generated from code on 2024-01-18 +This reference was automatically generated from code on 2024-02-01 .. _`TYPO3 Fluid ViewHelper Reference: f:alias`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst index 3d029b9f66..db095253a4 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst @@ -3,7 +3,7 @@ Flow TypeConverter Reference ============================ -This reference was automatically generated from code on 2024-01-18 +This reference was automatically generated from code on 2024-02-01 .. _`Flow TypeConverter Reference: ArrayConverter`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst index c643dcb0c1..27f59c05be 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst @@ -3,7 +3,7 @@ Flow Validator Reference ======================== -This reference was automatically generated from code on 2024-01-18 +This reference was automatically generated from code on 2024-02-01 .. _`Flow Validator Reference: AggregateBoundaryValidator`: From 99af27f9122ee1023276d47de025fd2aa5baeb7c Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Sun, 6 Feb 2022 23:11:14 +0100 Subject: [PATCH 08/29] BUGFIX: #2696 Web-Exception messages, preserve whitespace (ASCII Art) Exceptions which have multiple spaces in their $message where previously not as expected displayed. Exceptions outputted to the CLI or logged did preserve multiple whitespaces naturally, but since they are collapsed in HTML by default, they are not shown in the browser. --- Neos.Flow/Classes/Error/DebugExceptionHandler.php | 14 ++++++++++---- Neos.Flow/Resources/Public/Error/Exception.css | 8 ++++++++ 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/Neos.Flow/Classes/Error/DebugExceptionHandler.php b/Neos.Flow/Classes/Error/DebugExceptionHandler.php index 5c64ab867c..f64b7b4f0a 100644 --- a/Neos.Flow/Classes/Error/DebugExceptionHandler.php +++ b/Neos.Flow/Classes/Error/DebugExceptionHandler.php @@ -96,11 +96,17 @@ protected function renderStatically(int $statusCode, \Throwable $exception) while (true) { $filepaths = Debugger::findProxyAndShortFilePath($exception->getFile()); $filePathAndName = $filepaths['proxy'] !== '' ? $filepaths['proxy'] : $filepaths['short']; - $exceptionMessageParts = $this->splitExceptionMessage($exception->getMessage()); - $exceptionHeader .= '

' . htmlspecialchars($exceptionMessageParts['subject']) . '

'; - if ($exceptionMessageParts['body'] !== '') { - $exceptionHeader .= '

' . nl2br(htmlspecialchars($exceptionMessageParts['body'])) . '

'; + ['subject' => $exceptionMessageSubject, 'body' => $exceptionMessageBody] = $this->splitExceptionMessage($exception->getMessage()); + + $exceptionHeader .= '

' . htmlspecialchars($exceptionMessageSubject) . '

'; + if ($exceptionMessageBody !== '') { + if (str_contains($exceptionMessageBody, ' ')) { + // contents with multiple spaces will be pre-served + $exceptionHeader .= '

' . htmlspecialchars($exceptionMessageBody) . '

'; + } else { + $exceptionHeader .= '

' . nl2br(htmlspecialchars($exceptionMessageBody)) . '

'; + } } $exceptionHeader .= ''; diff --git a/Neos.Flow/Resources/Public/Error/Exception.css b/Neos.Flow/Resources/Public/Error/Exception.css index bf98d8ab6a..ef760647ee 100644 --- a/Neos.Flow/Resources/Public/Error/Exception.css +++ b/Neos.Flow/Resources/Public/Error/Exception.css @@ -47,6 +47,14 @@ h1, h2, h3 { color: #000000; } +.ExceptionBodyPre { + padding: 10px; + margin: 10px; + color: #000000; + white-space: pre; + font-family: Menlo, Monaco, Consolas, "Courier New", monospace; +} + .ExceptionProperty { color: #34363C; } From 84e8538c06484e970f1feeef5f53972224732d50 Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Mon, 25 Sep 2023 11:55:48 +0200 Subject: [PATCH 09/29] BUGFIX: 3178 reflection more descriptive error if annotation doesnt exist Resolves: #3178 --- Neos.Flow/Classes/Reflection/ReflectionService.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Neos.Flow/Classes/Reflection/ReflectionService.php b/Neos.Flow/Classes/Reflection/ReflectionService.php index 40d8a0ae30..91699bdc7f 100644 --- a/Neos.Flow/Classes/Reflection/ReflectionService.php +++ b/Neos.Flow/Classes/Reflection/ReflectionService.php @@ -1354,7 +1354,12 @@ public function reflectClassProperty($className, PropertyReflection $property) if ($this->isAttributeIgnored($attribute->getName())) { continue; } - $this->classReflectionData[$className][self::DATA_CLASS_PROPERTIES][$propertyName][self::DATA_PROPERTY_ANNOTATIONS][$attribute->getName()][] = $attribute->newInstance(); + try { + $attributeInstance = $attribute->newInstance(); + } catch (\Error $error) { + throw new \RuntimeException(sprintf('Attribute "%s" used in class "%s" was not found.', $attribute->getName(), $className), 1695635128, $error); + } + $this->classReflectionData[$className][self::DATA_CLASS_PROPERTIES][$propertyName][self::DATA_PROPERTY_ANNOTATIONS][$attribute->getName()][] = $attributeInstance; } } From 8d572f2b54bede156451c68e98468812243763d2 Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Sat, 3 Feb 2024 12:54:01 +0100 Subject: [PATCH 10/29] TASK: Add note to ReflectionService to remove isAttributeIgnored eventually --- Neos.Flow/Classes/Reflection/ReflectionService.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Neos.Flow/Classes/Reflection/ReflectionService.php b/Neos.Flow/Classes/Reflection/ReflectionService.php index 91699bdc7f..ab1b268c6e 100644 --- a/Neos.Flow/Classes/Reflection/ReflectionService.php +++ b/Neos.Flow/Classes/Reflection/ReflectionService.php @@ -779,6 +779,8 @@ public function isMethodTaggedWith($className, $methodName, $tag) */ public function isAttributeIgnored(string $attributeName): bool { + // Ignore attributes that only exist in specific versions of PHP (8.1) + // can be removed with Flow 9 if (in_array($attributeName, ['ReturnTypeWillChange']) && !class_exists($attributeName)) { return true; } From cb4fbba0d49bd2a344f93461d74a667f346cae44 Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Sat, 3 Feb 2024 12:00:09 +0100 Subject: [PATCH 11/29] TASK: ObjectManagement limit debugBacktrace --- .../Classes/ObjectManagement/Configuration/Configuration.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Neos.Flow/Classes/ObjectManagement/Configuration/Configuration.php b/Neos.Flow/Classes/ObjectManagement/Configuration/Configuration.php index cb591332d7..89296604c7 100644 --- a/Neos.Flow/Classes/ObjectManagement/Configuration/Configuration.php +++ b/Neos.Flow/Classes/ObjectManagement/Configuration/Configuration.php @@ -113,7 +113,7 @@ class Configuration */ public function __construct($objectName, $className = null) { - $backtrace = debug_backtrace(); + $backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 2); if (isset($backtrace[1]['object'])) { $this->configurationSourceHint = get_class($backtrace[1]['object']); } elseif (isset($backtrace[1]['class'])) { From 20ba6f0fb79321a5730239c18d1eeb94847def40 Mon Sep 17 00:00:00 2001 From: Marc Henry Schultz <85400359+mhsdesign@users.noreply.github.com> Date: Fri, 22 Sep 2023 09:56:23 +0200 Subject: [PATCH 12/29] TASK: Scripts.php avoid use of same references for exec $output _might_ in a really weird case be possibly already filled? But just to be clear we set it to empty. --- Neos.Flow/Classes/Core/Booting/Scripts.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Neos.Flow/Classes/Core/Booting/Scripts.php b/Neos.Flow/Classes/Core/Booting/Scripts.php index db88df4522..b3016c9729 100644 --- a/Neos.Flow/Classes/Core/Booting/Scripts.php +++ b/Neos.Flow/Classes/Core/Booting/Scripts.php @@ -861,6 +861,7 @@ protected static function ensureCLISubrequestsUseCurrentlyRunningPhpBinary($phpB $command[] = '2>&1'; // Output errors in response // Try to resolve which binary file PHP is pointing to + $output = []; exec(join(' ', $command), $output, $result); if ($result === 0 && count($output) === 1) { @@ -883,6 +884,7 @@ protected static function ensureCLISubrequestsUseCurrentlyRunningPhpBinary($phpB $realPhpBinary = @realpath(PHP_BINARY); if ($realPhpBinary === false) { // bypass with exec open_basedir restriction + $output = []; exec(PHP_BINARY . ' -r "echo realpath(PHP_BINARY);"', $output); $realPhpBinary = $output[0]; } From 6c6c5e9ec2c32a0fb9b7fd675f110ba8c01a254e Mon Sep 17 00:00:00 2001 From: Jenkins Date: Mon, 5 Feb 2024 12:41:15 +0000 Subject: [PATCH 13/29] TASK: Update references [skip ci] --- .../TheDefinitiveGuide/PartV/AnnotationReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/CommandReference.rst | 2 +- .../PartV/FluidAdaptorViewHelperReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TypeConverterReference.rst | 2 +- .../TheDefinitiveGuide/PartV/ValidatorReference.rst | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst index 1be610fd5c..4695c45f8d 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst @@ -3,7 +3,7 @@ Flow Annotation Reference ========================= -This reference was automatically generated from code on 2024-01-24 +This reference was automatically generated from code on 2024-02-05 .. _`Flow Annotation Reference: After`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst index 25cc8967b4..cc1e8fecb3 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst @@ -19,7 +19,7 @@ commands that may be available, use:: ./flow help -The following reference was automatically generated from code on 2024-01-24 +The following reference was automatically generated from code on 2024-02-05 .. _`Flow Command Reference: NEOS.FLOW`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst index d9b5947e21..a7c29dcbef 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst @@ -3,7 +3,7 @@ FluidAdaptor ViewHelper Reference ================================= -This reference was automatically generated from code on 2024-01-24 +This reference was automatically generated from code on 2024-02-05 .. _`FluidAdaptor ViewHelper Reference: f:debug`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst index 1b1cf71d7f..57b8454da3 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst @@ -3,7 +3,7 @@ Flow Signals Reference ====================== -This reference was automatically generated from code on 2024-01-24 +This reference was automatically generated from code on 2024-02-05 .. _`Flow Signals Reference: AbstractAdvice (``Neos\Flow\Aop\Advice\AbstractAdvice``)`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst index 05b71386e3..d591e9f421 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst @@ -3,7 +3,7 @@ TYPO3 Fluid ViewHelper Reference ================================ -This reference was automatically generated from code on 2024-01-24 +This reference was automatically generated from code on 2024-02-05 .. _`TYPO3 Fluid ViewHelper Reference: f:alias`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst index d233983508..bd7e040a7b 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst @@ -3,7 +3,7 @@ Flow TypeConverter Reference ============================ -This reference was automatically generated from code on 2024-01-24 +This reference was automatically generated from code on 2024-02-05 .. _`Flow TypeConverter Reference: ArrayConverter`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst index c35e78d3e8..a59f05c040 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst @@ -3,7 +3,7 @@ Flow Validator Reference ======================== -This reference was automatically generated from code on 2024-01-24 +This reference was automatically generated from code on 2024-02-05 .. _`Flow Validator Reference: AggregateBoundaryValidator`: From d8113012e7e52ec77d3bd643fbe3363c9e8ededd Mon Sep 17 00:00:00 2001 From: Jenkins Date: Tue, 6 Feb 2024 16:35:39 +0000 Subject: [PATCH 14/29] TASK: Update references [skip ci] --- .../TheDefinitiveGuide/PartV/AnnotationReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/CommandReference.rst | 2 +- .../PartV/FluidAdaptorViewHelperReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TypeConverterReference.rst | 2 +- .../TheDefinitiveGuide/PartV/ValidatorReference.rst | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst index 4695c45f8d..e9c55b6f5e 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst @@ -3,7 +3,7 @@ Flow Annotation Reference ========================= -This reference was automatically generated from code on 2024-02-05 +This reference was automatically generated from code on 2024-02-06 .. _`Flow Annotation Reference: After`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst index cc1e8fecb3..bce304618f 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst @@ -19,7 +19,7 @@ commands that may be available, use:: ./flow help -The following reference was automatically generated from code on 2024-02-05 +The following reference was automatically generated from code on 2024-02-06 .. _`Flow Command Reference: NEOS.FLOW`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst index a7c29dcbef..9e8157491c 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst @@ -3,7 +3,7 @@ FluidAdaptor ViewHelper Reference ================================= -This reference was automatically generated from code on 2024-02-05 +This reference was automatically generated from code on 2024-02-06 .. _`FluidAdaptor ViewHelper Reference: f:debug`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst index 57b8454da3..e3782e6361 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst @@ -3,7 +3,7 @@ Flow Signals Reference ====================== -This reference was automatically generated from code on 2024-02-05 +This reference was automatically generated from code on 2024-02-06 .. _`Flow Signals Reference: AbstractAdvice (``Neos\Flow\Aop\Advice\AbstractAdvice``)`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst index d591e9f421..083bf57b87 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst @@ -3,7 +3,7 @@ TYPO3 Fluid ViewHelper Reference ================================ -This reference was automatically generated from code on 2024-02-05 +This reference was automatically generated from code on 2024-02-06 .. _`TYPO3 Fluid ViewHelper Reference: f:alias`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst index bd7e040a7b..d41034abf7 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst @@ -3,7 +3,7 @@ Flow TypeConverter Reference ============================ -This reference was automatically generated from code on 2024-02-05 +This reference was automatically generated from code on 2024-02-06 .. _`Flow TypeConverter Reference: ArrayConverter`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst index a59f05c040..347b524aa8 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst @@ -3,7 +3,7 @@ Flow Validator Reference ======================== -This reference was automatically generated from code on 2024-02-05 +This reference was automatically generated from code on 2024-02-06 .. _`Flow Validator Reference: AggregateBoundaryValidator`: From 0ebc3bc1e9f71f1da0d3d8c2e759dc3c427ea1cf Mon Sep 17 00:00:00 2001 From: Jenkins Date: Fri, 9 Feb 2024 14:53:25 +0000 Subject: [PATCH 15/29] TASK: Update references [skip ci] --- .../TheDefinitiveGuide/PartV/AnnotationReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/CommandReference.rst | 2 +- .../PartV/FluidAdaptorViewHelperReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TypeConverterReference.rst | 2 +- .../TheDefinitiveGuide/PartV/ValidatorReference.rst | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst index e9c55b6f5e..418e92a807 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst @@ -3,7 +3,7 @@ Flow Annotation Reference ========================= -This reference was automatically generated from code on 2024-02-06 +This reference was automatically generated from code on 2024-02-09 .. _`Flow Annotation Reference: After`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst index bce304618f..f84d4ec948 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst @@ -19,7 +19,7 @@ commands that may be available, use:: ./flow help -The following reference was automatically generated from code on 2024-02-06 +The following reference was automatically generated from code on 2024-02-09 .. _`Flow Command Reference: NEOS.FLOW`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst index 9e8157491c..7fdcf8281f 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst @@ -3,7 +3,7 @@ FluidAdaptor ViewHelper Reference ================================= -This reference was automatically generated from code on 2024-02-06 +This reference was automatically generated from code on 2024-02-09 .. _`FluidAdaptor ViewHelper Reference: f:debug`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst index e3782e6361..8f2de6efb0 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst @@ -3,7 +3,7 @@ Flow Signals Reference ====================== -This reference was automatically generated from code on 2024-02-06 +This reference was automatically generated from code on 2024-02-09 .. _`Flow Signals Reference: AbstractAdvice (``Neos\Flow\Aop\Advice\AbstractAdvice``)`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst index 083bf57b87..33cbb9fe49 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst @@ -3,7 +3,7 @@ TYPO3 Fluid ViewHelper Reference ================================ -This reference was automatically generated from code on 2024-02-06 +This reference was automatically generated from code on 2024-02-09 .. _`TYPO3 Fluid ViewHelper Reference: f:alias`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst index d41034abf7..71af6d6bf8 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst @@ -3,7 +3,7 @@ Flow TypeConverter Reference ============================ -This reference was automatically generated from code on 2024-02-06 +This reference was automatically generated from code on 2024-02-09 .. _`Flow TypeConverter Reference: ArrayConverter`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst index 347b524aa8..463b5f6190 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst @@ -3,7 +3,7 @@ Flow Validator Reference ======================== -This reference was automatically generated from code on 2024-02-06 +This reference was automatically generated from code on 2024-02-09 .. _`Flow Validator Reference: AggregateBoundaryValidator`: From e07a24f017eead1e56d1cf5c6ce6646da1dfaf08 Mon Sep 17 00:00:00 2001 From: Sebastian Helzle Date: Wed, 14 Feb 2024 08:32:52 +0100 Subject: [PATCH 16/29] BUGFIX: Use configured cache factory The previously used method to select the configured CacheFactory class from the Objects.yaml never returned a result as the raw configuration split by package name was accessed, therefore the fallback was used and it was not possible to provide a custom CacheFactory. Resolves: #3317 --- Neos.Flow/Classes/Cache/CacheManager.php | 7 ++++--- Neos.Flow/Classes/Core/Booting/Scripts.php | 11 ++++++++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/Neos.Flow/Classes/Cache/CacheManager.php b/Neos.Flow/Classes/Cache/CacheManager.php index 1ca19ca382..d1c0221671 100644 --- a/Neos.Flow/Classes/Cache/CacheManager.php +++ b/Neos.Flow/Classes/Cache/CacheManager.php @@ -11,6 +11,7 @@ * source code. */ +use Neos\Cache\CacheFactoryInterface; use Neos\Flow\Annotations as Flow; use Neos\Cache\Backend\FileBackend; use Neos\Cache\Exception\DuplicateIdentifierException; @@ -37,7 +38,7 @@ class CacheManager { /** - * @var CacheFactory + * @var CacheFactoryInterface */ protected $cacheFactory; @@ -100,10 +101,10 @@ public function injectLogger(LoggerInterface $logger) } /** - * @param CacheFactory $cacheFactory + * @param CacheFactoryInterface $cacheFactory * @return void */ - public function injectCacheFactory(CacheFactory $cacheFactory): void + public function injectCacheFactory(CacheFactoryInterface $cacheFactory): void { $this->cacheFactory = $cacheFactory; } diff --git a/Neos.Flow/Classes/Core/Booting/Scripts.php b/Neos.Flow/Classes/Core/Booting/Scripts.php index 8123cd3f1f..c753def8af 100644 --- a/Neos.Flow/Classes/Core/Booting/Scripts.php +++ b/Neos.Flow/Classes/Core/Booting/Scripts.php @@ -356,10 +356,15 @@ public static function initializeCacheManagement(Bootstrap $bootstrap) $configurationManager = $bootstrap->getEarlyInstance(ConfigurationManager::class); $environment = $bootstrap->getEarlyInstance(Environment::class); - $cacheFactoryObjectConfiguration = $configurationManager->getConfiguration(ConfigurationManager::CONFIGURATION_TYPE_OBJECTS, CacheFactoryInterface::class); - $cacheFactoryClass = isset($cacheFactoryObjectConfiguration['className']) ? $cacheFactoryObjectConfiguration['className'] : CacheFactory::class; + $cacheFactoryClass = null; + $cacheFactoryObjectConfiguration = $configurationManager->getConfiguration(ConfigurationManager::CONFIGURATION_TYPE_OBJECTS); + foreach ($cacheFactoryObjectConfiguration as $objectConfiguration) { + if (isset($objectConfiguration[CacheFactoryInterface::class])) { + $cacheFactoryClass = $objectConfiguration[CacheFactoryInterface::class]['className'] ?? CacheFactory::class; + } + } - /** @var CacheFactory $cacheFactory */ + /** @var CacheFactoryInterface $cacheFactory */ $cacheFactory = new $cacheFactoryClass($bootstrap->getContext(), $environment, $configurationManager->getConfiguration(ConfigurationManager::CONFIGURATION_TYPE_SETTINGS, 'Neos.Flow.cache.applicationIdentifier')); $cacheManager = new CacheManager(); From 397fa79fd3705f0ce9bc3b3cc6bf64cbdffcf229 Mon Sep 17 00:00:00 2001 From: Sebastian Helzle Date: Wed, 14 Feb 2024 17:14:27 +0100 Subject: [PATCH 17/29] TASK: Add note about resolving the CacheFactory implementation --- Neos.Flow/Classes/Core/Booting/Scripts.php | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Neos.Flow/Classes/Core/Booting/Scripts.php b/Neos.Flow/Classes/Core/Booting/Scripts.php index c753def8af..a3c5c384c8 100644 --- a/Neos.Flow/Classes/Core/Booting/Scripts.php +++ b/Neos.Flow/Classes/Core/Booting/Scripts.php @@ -356,11 +356,14 @@ public static function initializeCacheManagement(Bootstrap $bootstrap) $configurationManager = $bootstrap->getEarlyInstance(ConfigurationManager::class); $environment = $bootstrap->getEarlyInstance(Environment::class); - $cacheFactoryClass = null; + // Workaround to find the correct CacheFactory implementation at compile time. + // We can rely on the $objectConfiguration being ordered by the package names after their loading order. + // Normally this wiring would be done for proxy building a similar way, see ConfigurationBuilder. + $cacheFactoryClass = CacheFactory::class; $cacheFactoryObjectConfiguration = $configurationManager->getConfiguration(ConfigurationManager::CONFIGURATION_TYPE_OBJECTS); foreach ($cacheFactoryObjectConfiguration as $objectConfiguration) { - if (isset($objectConfiguration[CacheFactoryInterface::class])) { - $cacheFactoryClass = $objectConfiguration[CacheFactoryInterface::class]['className'] ?? CacheFactory::class; + if (isset($objectConfiguration[CacheFactoryInterface::class]['className'])) { + $cacheFactoryClass = $objectConfiguration[CacheFactoryInterface::class]['className']; } } From 6a32dfeb08fa93a04db44028193a9daa4652a128 Mon Sep 17 00:00:00 2001 From: Sebastian Helzle Date: Wed, 14 Feb 2024 17:14:54 +0100 Subject: [PATCH 18/29] TASK: Remove unused cacheManager from the CacheFactory --- Neos.Flow/Classes/Cache/CacheFactory.php | 16 ---------------- Neos.Flow/Classes/Core/Booting/Scripts.php | 2 -- 2 files changed, 18 deletions(-) diff --git a/Neos.Flow/Classes/Cache/CacheFactory.php b/Neos.Flow/Classes/Cache/CacheFactory.php index 943ff3b23e..9d498cf2cf 100644 --- a/Neos.Flow/Classes/Cache/CacheFactory.php +++ b/Neos.Flow/Classes/Cache/CacheFactory.php @@ -38,13 +38,6 @@ class CacheFactory extends \Neos\Cache\CacheFactory */ protected $context; - /** - * A reference to the cache manager - * - * @var CacheManager - */ - protected $cacheManager; - /** * @var Environment */ @@ -55,15 +48,6 @@ class CacheFactory extends \Neos\Cache\CacheFactory */ protected $environmentConfiguration; - /** - * @param CacheManager $cacheManager - * @Flow\Autowiring(enabled=false) - */ - public function injectCacheManager(CacheManager $cacheManager) - { - $this->cacheManager = $cacheManager; - } - /** * @param EnvironmentConfiguration $environmentConfiguration * @Flow\Autowiring(enabled=false) diff --git a/Neos.Flow/Classes/Core/Booting/Scripts.php b/Neos.Flow/Classes/Core/Booting/Scripts.php index a3c5c384c8..55730cba91 100644 --- a/Neos.Flow/Classes/Core/Booting/Scripts.php +++ b/Neos.Flow/Classes/Core/Booting/Scripts.php @@ -377,8 +377,6 @@ public static function initializeCacheManagement(Bootstrap $bootstrap) $cacheManager->injectEnvironment($environment); $cacheManager->injectCacheFactory($cacheFactory); - $cacheFactory->injectCacheManager($cacheManager); - $bootstrap->setEarlyInstance(CacheManager::class, $cacheManager); $bootstrap->setEarlyInstance(CacheFactory::class, $cacheFactory); } From 1f1c70a93575f4d544361d40675b93a14bd2a1cc Mon Sep 17 00:00:00 2001 From: Sebastian Helzle Date: Wed, 14 Feb 2024 17:19:36 +0100 Subject: [PATCH 19/29] TASK: Adjust CacheFactory test --- Neos.Flow/Tests/Unit/Cache/CacheFactoryTest.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/Neos.Flow/Tests/Unit/Cache/CacheFactoryTest.php b/Neos.Flow/Tests/Unit/Cache/CacheFactoryTest.php index e918d8bbe4..62eb9617d8 100644 --- a/Neos.Flow/Tests/Unit/Cache/CacheFactoryTest.php +++ b/Neos.Flow/Tests/Unit/Cache/CacheFactoryTest.php @@ -99,9 +99,7 @@ public function createInjectsAnInstanceOfTheSpecifiedBackendIntoTheCacheFrontend */ public function aDifferentDefaultCacheDirectoryIsUsedForPersistentFileCaches() { - $cacheManager = new CacheManager(); $factory = new CacheFactory(new ApplicationContext('Testing'), $this->mockEnvironment, 'UnitTesting'); - $factory->injectCacheManager($cacheManager); $factory->injectEnvironmentConfiguration($this->mockEnvironmentConfiguration); $cache = $factory->create('Persistent_Cache', VariableFrontend::class, FileBackend::class, [], true); From a302b45b38dce8ccb65b15e8cfee6336ad994f4d Mon Sep 17 00:00:00 2001 From: Lars Lauger Date: Thu, 15 Feb 2024 15:44:38 +0100 Subject: [PATCH 20/29] BUGFIX: Normalize source type for converting floats to ValueObjects gettype will return "double" for floats which will never match to the normalized type of the ValueObject's constructor argument --- .../ScalarTypeToObjectConverter.php | 2 +- .../Fixtures/ClassWithFloatConstructor.php | 33 +++++++++++++++++++ .../Fixtures/ClassWithIntegerConstructor.php | 2 +- .../ScalarTypeToObjectConverterTest.php | 18 ++++++++++ 4 files changed, 53 insertions(+), 2 deletions(-) create mode 100644 Neos.Flow/Tests/Unit/Fixtures/ClassWithFloatConstructor.php diff --git a/Neos.Flow/Classes/Property/TypeConverter/ScalarTypeToObjectConverter.php b/Neos.Flow/Classes/Property/TypeConverter/ScalarTypeToObjectConverter.php index 2dcad21ff1..4a3dbc7bf2 100644 --- a/Neos.Flow/Classes/Property/TypeConverter/ScalarTypeToObjectConverter.php +++ b/Neos.Flow/Classes/Property/TypeConverter/ScalarTypeToObjectConverter.php @@ -71,7 +71,7 @@ public function canConvertFrom($source, $targetType) return false; } $methodParameter = array_shift($methodParameters); - return TypeHandling::normalizeType($methodParameter['type']) === gettype($source); + return TypeHandling::normalizeType($methodParameter['type']) === TypeHandling::normalizeType(gettype($source)); } /** diff --git a/Neos.Flow/Tests/Unit/Fixtures/ClassWithFloatConstructor.php b/Neos.Flow/Tests/Unit/Fixtures/ClassWithFloatConstructor.php new file mode 100644 index 0000000000..72aa870a1a --- /dev/null +++ b/Neos.Flow/Tests/Unit/Fixtures/ClassWithFloatConstructor.php @@ -0,0 +1,33 @@ +value = $value; + } +} diff --git a/Neos.Flow/Tests/Unit/Fixtures/ClassWithIntegerConstructor.php b/Neos.Flow/Tests/Unit/Fixtures/ClassWithIntegerConstructor.php index 5f7ef298bb..1635e7f9fa 100644 --- a/Neos.Flow/Tests/Unit/Fixtures/ClassWithIntegerConstructor.php +++ b/Neos.Flow/Tests/Unit/Fixtures/ClassWithIntegerConstructor.php @@ -17,7 +17,7 @@ class ClassWithIntegerConstructor { /** - * @var string + * @var int */ public $value; diff --git a/Neos.Flow/Tests/Unit/Property/TypeConverter/ScalarTypeToObjectConverterTest.php b/Neos.Flow/Tests/Unit/Property/TypeConverter/ScalarTypeToObjectConverterTest.php index 71a44eb013..87005cf196 100644 --- a/Neos.Flow/Tests/Unit/Property/TypeConverter/ScalarTypeToObjectConverterTest.php +++ b/Neos.Flow/Tests/Unit/Property/TypeConverter/ScalarTypeToObjectConverterTest.php @@ -16,6 +16,7 @@ require_once(__DIR__ . '/../../Fixtures/ClassWithBoolConstructor.php'); use Neos\Flow\Fixtures\ClassWithBoolConstructor; +use Neos\Flow\Fixtures\ClassWithFloatConstructor; use Neos\Flow\Fixtures\ClassWithIntegerConstructor; use Neos\Flow\Fixtures\ClassWithStringConstructor; use Neos\Flow\Property\TypeConverter\ScalarTypeToObjectConverter; @@ -108,4 +109,21 @@ public function canConvertFromIntegerToValueObject() $canConvert = $converter->canConvertFrom(42, ClassWithIntegerConstructor::class); self::assertTrue($canConvert); } + + /** + * @test + */ + public function canConvertFromFloatToValueObject() + { + $converter = new ScalarTypeToObjectConverter(); + + $this->reflectionMock->expects(self::once()) + ->method('getMethodParameters') + ->willReturn([[ + 'type' => 'float' + ]]); + $this->inject($converter, 'reflectionService', $this->reflectionMock); + $canConvert = $converter->canConvertFrom(4.2, ClassWithFloatConstructor::class); + self::assertTrue($canConvert); + } } From e7ecdf2bdee316ee7f1529079fa51ac783e73ff5 Mon Sep 17 00:00:00 2001 From: Jenkins Date: Fri, 16 Feb 2024 16:28:50 +0000 Subject: [PATCH 21/29] TASK: Update references [skip ci] --- .../TheDefinitiveGuide/PartV/AnnotationReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/CommandReference.rst | 2 +- .../PartV/FluidAdaptorViewHelperReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TypeConverterReference.rst | 2 +- .../TheDefinitiveGuide/PartV/ValidatorReference.rst | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst index 418e92a807..555c570a98 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst @@ -3,7 +3,7 @@ Flow Annotation Reference ========================= -This reference was automatically generated from code on 2024-02-09 +This reference was automatically generated from code on 2024-02-16 .. _`Flow Annotation Reference: After`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst index f84d4ec948..b85234c02c 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst @@ -19,7 +19,7 @@ commands that may be available, use:: ./flow help -The following reference was automatically generated from code on 2024-02-09 +The following reference was automatically generated from code on 2024-02-16 .. _`Flow Command Reference: NEOS.FLOW`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst index 7fdcf8281f..8295f22479 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst @@ -3,7 +3,7 @@ FluidAdaptor ViewHelper Reference ================================= -This reference was automatically generated from code on 2024-02-09 +This reference was automatically generated from code on 2024-02-16 .. _`FluidAdaptor ViewHelper Reference: f:debug`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst index 8f2de6efb0..f48eb12f7a 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst @@ -3,7 +3,7 @@ Flow Signals Reference ====================== -This reference was automatically generated from code on 2024-02-09 +This reference was automatically generated from code on 2024-02-16 .. _`Flow Signals Reference: AbstractAdvice (``Neos\Flow\Aop\Advice\AbstractAdvice``)`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst index 33cbb9fe49..87f0392cb5 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst @@ -3,7 +3,7 @@ TYPO3 Fluid ViewHelper Reference ================================ -This reference was automatically generated from code on 2024-02-09 +This reference was automatically generated from code on 2024-02-16 .. _`TYPO3 Fluid ViewHelper Reference: f:alias`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst index 71af6d6bf8..5c0471c3e9 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst @@ -3,7 +3,7 @@ Flow TypeConverter Reference ============================ -This reference was automatically generated from code on 2024-02-09 +This reference was automatically generated from code on 2024-02-16 .. _`Flow TypeConverter Reference: ArrayConverter`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst index 463b5f6190..d8728f0215 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst @@ -3,7 +3,7 @@ Flow Validator Reference ======================== -This reference was automatically generated from code on 2024-02-09 +This reference was automatically generated from code on 2024-02-16 .. _`Flow Validator Reference: AggregateBoundaryValidator`: From 8bff583a3e67cb639d4797f2d9c7255ebaf9a2bc Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Tue, 13 Feb 2024 15:16:48 +0100 Subject: [PATCH 22/29] TASK: Fix phpstan by removing dead code > Access to an undefined property Neos\Flow\Mvc\Controller\Arguments::$argumentShortNames. --- Neos.Flow/Classes/Mvc/Controller/Arguments.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/Neos.Flow/Classes/Mvc/Controller/Arguments.php b/Neos.Flow/Classes/Mvc/Controller/Arguments.php index 031c9d2618..e1cd786534 100644 --- a/Neos.Flow/Classes/Mvc/Controller/Arguments.php +++ b/Neos.Flow/Classes/Mvc/Controller/Arguments.php @@ -78,9 +78,6 @@ public function offsetUnset($offset): void parent::offsetUnset($translatedOffset); unset($this->argumentNames[$translatedOffset]); - if ($offset != $translatedOffset) { - unset($this->argumentShortNames[$offset]); - } } /** From 027ebcaa8fb1789cfcf5edd6e53c562ad0536305 Mon Sep 17 00:00:00 2001 From: Jenkins Date: Fri, 16 Feb 2024 16:31:38 +0000 Subject: [PATCH 23/29] TASK: Update references [skip ci] --- .../TheDefinitiveGuide/PartV/AnnotationReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/CommandReference.rst | 2 +- .../PartV/FluidAdaptorViewHelperReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TypeConverterReference.rst | 2 +- .../TheDefinitiveGuide/PartV/ValidatorReference.rst | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst index 8bf8f01a96..555c570a98 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst @@ -3,7 +3,7 @@ Flow Annotation Reference ========================= -This reference was automatically generated from code on 2024-01-04 +This reference was automatically generated from code on 2024-02-16 .. _`Flow Annotation Reference: After`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst index c910372f58..ef6a32d13c 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst @@ -19,7 +19,7 @@ commands that may be available, use:: ./flow help -The following reference was automatically generated from code on 2024-01-04 +The following reference was automatically generated from code on 2024-02-16 .. _`Flow Command Reference: NEOS.FLOW`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst index f91410d364..8295f22479 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst @@ -3,7 +3,7 @@ FluidAdaptor ViewHelper Reference ================================= -This reference was automatically generated from code on 2024-01-04 +This reference was automatically generated from code on 2024-02-16 .. _`FluidAdaptor ViewHelper Reference: f:debug`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst index 9428955593..f48eb12f7a 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst @@ -3,7 +3,7 @@ Flow Signals Reference ====================== -This reference was automatically generated from code on 2024-01-04 +This reference was automatically generated from code on 2024-02-16 .. _`Flow Signals Reference: AbstractAdvice (``Neos\Flow\Aop\Advice\AbstractAdvice``)`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst index e3244d3262..87f0392cb5 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst @@ -3,7 +3,7 @@ TYPO3 Fluid ViewHelper Reference ================================ -This reference was automatically generated from code on 2024-01-04 +This reference was automatically generated from code on 2024-02-16 .. _`TYPO3 Fluid ViewHelper Reference: f:alias`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst index 561cfa0560..5c0471c3e9 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst @@ -3,7 +3,7 @@ Flow TypeConverter Reference ============================ -This reference was automatically generated from code on 2024-01-04 +This reference was automatically generated from code on 2024-02-16 .. _`Flow TypeConverter Reference: ArrayConverter`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst index f59006bc39..f64bc9b765 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst @@ -3,7 +3,7 @@ Flow Validator Reference ======================== -This reference was automatically generated from code on 2024-01-04 +This reference was automatically generated from code on 2024-02-16 .. _`Flow Validator Reference: AggregateBoundaryValidator`: From e12888548d910973ddf855aea5454746c1bd71ce Mon Sep 17 00:00:00 2001 From: Sebastian Helzle Date: Wed, 21 Feb 2024 14:26:14 +0100 Subject: [PATCH 24/29] TASK: Ignore phpstan warning for now We need to adjust the interface in the future to allow persistent caches. --- Neos.Flow/Classes/Cache/CacheManager.php | 1 + 1 file changed, 1 insertion(+) diff --git a/Neos.Flow/Classes/Cache/CacheManager.php b/Neos.Flow/Classes/Cache/CacheManager.php index d1c0221671..ede879875d 100644 --- a/Neos.Flow/Classes/Cache/CacheManager.php +++ b/Neos.Flow/Classes/Cache/CacheManager.php @@ -497,6 +497,7 @@ protected function createCache(string $identifier): void $backend = isset($this->cacheConfigurations[$identifier]['backend']) ? $this->cacheConfigurations[$identifier]['backend'] : $this->cacheConfigurations['Default']['backend']; $backendOptions = isset($this->cacheConfigurations[$identifier]['backendOptions']) ? $this->cacheConfigurations[$identifier]['backendOptions'] : $this->cacheConfigurations['Default']['backendOptions']; $persistent = isset($this->cacheConfigurations[$identifier]['persistent']) ? $this->cacheConfigurations[$identifier]['persistent'] : $this->cacheConfigurations['Default']['persistent']; + // @phpstan-ignore-next-line - $persistent is not yet part of the CacheFactoryInterface $cache = $this->cacheFactory->create($identifier, $frontend, $backend, $backendOptions, $persistent); $this->registerCache($cache, $persistent); } From ce953bfab3672f882a814a332664601faf1e2eae Mon Sep 17 00:00:00 2001 From: Jenkins Date: Wed, 21 Feb 2024 15:08:04 +0000 Subject: [PATCH 25/29] TASK: Update references [skip ci] --- .../TheDefinitiveGuide/PartV/AnnotationReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/CommandReference.rst | 2 +- .../PartV/FluidAdaptorViewHelperReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TypeConverterReference.rst | 2 +- .../TheDefinitiveGuide/PartV/ValidatorReference.rst | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst index 555c570a98..9c42048c8f 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst @@ -3,7 +3,7 @@ Flow Annotation Reference ========================= -This reference was automatically generated from code on 2024-02-16 +This reference was automatically generated from code on 2024-02-21 .. _`Flow Annotation Reference: After`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst index b85234c02c..b2ab056d49 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst @@ -19,7 +19,7 @@ commands that may be available, use:: ./flow help -The following reference was automatically generated from code on 2024-02-16 +The following reference was automatically generated from code on 2024-02-21 .. _`Flow Command Reference: NEOS.FLOW`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst index 8295f22479..4f8614dc89 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst @@ -3,7 +3,7 @@ FluidAdaptor ViewHelper Reference ================================= -This reference was automatically generated from code on 2024-02-16 +This reference was automatically generated from code on 2024-02-21 .. _`FluidAdaptor ViewHelper Reference: f:debug`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst index f48eb12f7a..b3ad3bd917 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst @@ -3,7 +3,7 @@ Flow Signals Reference ====================== -This reference was automatically generated from code on 2024-02-16 +This reference was automatically generated from code on 2024-02-21 .. _`Flow Signals Reference: AbstractAdvice (``Neos\Flow\Aop\Advice\AbstractAdvice``)`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst index 87f0392cb5..d0f92adee5 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst @@ -3,7 +3,7 @@ TYPO3 Fluid ViewHelper Reference ================================ -This reference was automatically generated from code on 2024-02-16 +This reference was automatically generated from code on 2024-02-21 .. _`TYPO3 Fluid ViewHelper Reference: f:alias`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst index 5c0471c3e9..1da74c6e43 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst @@ -3,7 +3,7 @@ Flow TypeConverter Reference ============================ -This reference was automatically generated from code on 2024-02-16 +This reference was automatically generated from code on 2024-02-21 .. _`Flow TypeConverter Reference: ArrayConverter`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst index d8728f0215..46e96fe1d4 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst @@ -3,7 +3,7 @@ Flow Validator Reference ======================== -This reference was automatically generated from code on 2024-02-16 +This reference was automatically generated from code on 2024-02-21 .. _`Flow Validator Reference: AggregateBoundaryValidator`: From 23068e7f2363c9c4a2ae1d30c59a241280a08ba9 Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Thu, 22 Feb 2024 10:37:11 +0100 Subject: [PATCH 26/29] TASK: Refine comment why `getClassNameByObjectName` must be used instead of manually traversing `CONFIGURATION_TYPE_OBJECTS` --- Neos.Flow/Classes/Core/Booting/Scripts.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Neos.Flow/Classes/Core/Booting/Scripts.php b/Neos.Flow/Classes/Core/Booting/Scripts.php index 55730cba91..35f31d8ef1 100644 --- a/Neos.Flow/Classes/Core/Booting/Scripts.php +++ b/Neos.Flow/Classes/Core/Booting/Scripts.php @@ -356,13 +356,17 @@ public static function initializeCacheManagement(Bootstrap $bootstrap) $configurationManager = $bootstrap->getEarlyInstance(ConfigurationManager::class); $environment = $bootstrap->getEarlyInstance(Environment::class); - // Workaround to find the correct CacheFactory implementation at compile time. - // We can rely on the $objectConfiguration being ordered by the package names after their loading order. - // Normally this wiring would be done for proxy building a similar way, see ConfigurationBuilder. + /** + * Workaround to find the correct CacheFactory implementation at compile time. + * We can rely on the $objectConfiguration being ordered by the package names after their loading order. + * The object manager _does_ even know that at a later step in compile time: {@see CompileTimeObjectManager::getClassNameByObjectName()} + * But at this time it is not available. https://github.com/neos/flow-development-collection/issues/3317 + */ $cacheFactoryClass = CacheFactory::class; $cacheFactoryObjectConfiguration = $configurationManager->getConfiguration(ConfigurationManager::CONFIGURATION_TYPE_OBJECTS); foreach ($cacheFactoryObjectConfiguration as $objectConfiguration) { if (isset($objectConfiguration[CacheFactoryInterface::class]['className'])) { + // use the implementation of the package with the highest loading order $cacheFactoryClass = $objectConfiguration[CacheFactoryInterface::class]['className']; } } From 8b2f13ee3f940bbf25937929eeec798a97f61817 Mon Sep 17 00:00:00 2001 From: Jenkins Date: Thu, 22 Feb 2024 09:38:20 +0000 Subject: [PATCH 27/29] TASK: Update references [skip ci] --- .../TheDefinitiveGuide/PartV/AnnotationReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/CommandReference.rst | 2 +- .../PartV/FluidAdaptorViewHelperReference.rst | 2 +- .../Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst | 2 +- .../TheDefinitiveGuide/PartV/TypeConverterReference.rst | 2 +- .../TheDefinitiveGuide/PartV/ValidatorReference.rst | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst index 9c42048c8f..9346d10124 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/AnnotationReference.rst @@ -3,7 +3,7 @@ Flow Annotation Reference ========================= -This reference was automatically generated from code on 2024-02-21 +This reference was automatically generated from code on 2024-02-22 .. _`Flow Annotation Reference: After`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst index b2ab056d49..5629038a72 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/CommandReference.rst @@ -19,7 +19,7 @@ commands that may be available, use:: ./flow help -The following reference was automatically generated from code on 2024-02-21 +The following reference was automatically generated from code on 2024-02-22 .. _`Flow Command Reference: NEOS.FLOW`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst index 4f8614dc89..7639e3f43b 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/FluidAdaptorViewHelperReference.rst @@ -3,7 +3,7 @@ FluidAdaptor ViewHelper Reference ================================= -This reference was automatically generated from code on 2024-02-21 +This reference was automatically generated from code on 2024-02-22 .. _`FluidAdaptor ViewHelper Reference: f:debug`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst index b3ad3bd917..966ca11363 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/SignalsReference.rst @@ -3,7 +3,7 @@ Flow Signals Reference ====================== -This reference was automatically generated from code on 2024-02-21 +This reference was automatically generated from code on 2024-02-22 .. _`Flow Signals Reference: AbstractAdvice (``Neos\Flow\Aop\Advice\AbstractAdvice``)`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst index d0f92adee5..8826cfb028 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TYPO3FluidViewHelperReference.rst @@ -3,7 +3,7 @@ TYPO3 Fluid ViewHelper Reference ================================ -This reference was automatically generated from code on 2024-02-21 +This reference was automatically generated from code on 2024-02-22 .. _`TYPO3 Fluid ViewHelper Reference: f:alias`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst index 1da74c6e43..76cde8f9d1 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/TypeConverterReference.rst @@ -3,7 +3,7 @@ Flow TypeConverter Reference ============================ -This reference was automatically generated from code on 2024-02-21 +This reference was automatically generated from code on 2024-02-22 .. _`Flow TypeConverter Reference: ArrayConverter`: diff --git a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst index 46e96fe1d4..900309d1df 100644 --- a/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst +++ b/Neos.Flow/Documentation/TheDefinitiveGuide/PartV/ValidatorReference.rst @@ -3,7 +3,7 @@ Flow Validator Reference ======================== -This reference was automatically generated from code on 2024-02-21 +This reference was automatically generated from code on 2024-02-22 .. _`Flow Validator Reference: AggregateBoundaryValidator`: From ed00b707e470d2ba46772829379c02382adb17c6 Mon Sep 17 00:00:00 2001 From: Karsten Dambekalns Date: Mon, 4 Dec 2023 18:42:16 +0100 Subject: [PATCH 28/29] BUGFIX: No stack trace dumped for InvalidHashException in Production This configures a `noStacktraceExceptionGroup` exception handler rendering group and configures it to not dump stack traces in `Production` context. For `Development` context stack traces are still written to ease debugging. The rendering group contains only the `InvalidHashException` for now. See #3159 --- Neos.Flow/Configuration/Development/Settings.yaml | 5 +++++ Neos.Flow/Configuration/Settings.Error.yaml | 9 ++++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/Neos.Flow/Configuration/Development/Settings.yaml b/Neos.Flow/Configuration/Development/Settings.yaml index fb918eef38..47095b5141 100644 --- a/Neos.Flow/Configuration/Development/Settings.yaml +++ b/Neos.Flow/Configuration/Development/Settings.yaml @@ -23,6 +23,11 @@ Neos: defaultRenderingOptions: renderTechnicalDetails: true + renderingGroups: + noStacktraceExceptionGroup: + options: + logException: true + errorHandler: exceptionalErrors: ['%E_USER_ERROR%', '%E_RECOVERABLE_ERROR%', '%E_WARNING%', '%E_NOTICE%', '%E_USER_WARNING%', '%E_USER_NOTICE%', '%E_STRICT%'] diff --git a/Neos.Flow/Configuration/Settings.Error.yaml b/Neos.Flow/Configuration/Settings.Error.yaml index f15f78ba93..63af66b2e6 100644 --- a/Neos.Flow/Configuration/Settings.Error.yaml +++ b/Neos.Flow/Configuration/Settings.Error.yaml @@ -37,6 +37,14 @@ Neos: variables: errorDescription: 'Sorry, the database connection couldn''t be established.' + noStacktraceExceptionGroup: + matchingExceptionClassNames: ['Neos\Flow\Security\Exception\InvalidHashException'] + options: + logException: false + templatePathAndFilename: 'resource://Neos.Flow/Private/Templates/Error/Default.html' + variables: + errorDescription: 'Sorry, something went wrong.' + errorHandler: # Defines which errors should result in an exception thrown - all other error @@ -71,4 +79,3 @@ Neos: # Maximal recursion for the debugger recursionLimit: 5 - From 5f29d107f6132cca7b26e5765a37409ef2e2e664 Mon Sep 17 00:00:00 2001 From: Karsten Dambekalns Date: Fri, 23 Feb 2024 11:13:44 +0100 Subject: [PATCH 29/29] TASK: Undo direct logging of invalid HMAC exception This undoes PR #2685 as it is no longer needed: That exception is no longer a 500 (since PR #3234) and this very PR makes sure that the specific exception is no longer dumping a trace. --- Neos.Flow/Classes/Mvc/Controller/ActionController.php | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/Neos.Flow/Classes/Mvc/Controller/ActionController.php b/Neos.Flow/Classes/Mvc/Controller/ActionController.php index 2209baa52d..01f27158b8 100644 --- a/Neos.Flow/Classes/Mvc/Controller/ActionController.php +++ b/Neos.Flow/Classes/Mvc/Controller/ActionController.php @@ -31,8 +31,6 @@ use Neos\Flow\Property\Exception\TargetNotFoundException; use Neos\Flow\Property\TypeConverter\Error\TargetNotFoundError; use Neos\Flow\Reflection\ReflectionService; -use Neos\Flow\Security\Exception\InvalidArgumentForHashGenerationException; -use Neos\Flow\Security\Exception\InvalidHashException; use Neos\Utility\TypeHandling; use Psr\Http\Message\ResponseInterface; use Psr\Http\Message\StreamInterface; @@ -227,13 +225,8 @@ public function processRequest(ActionRequest $request, ActionResponse $response) if (method_exists($this, $actionInitializationMethodName)) { call_user_func([$this, $actionInitializationMethodName]); } - try { - $this->mvcPropertyMappingConfigurationService->initializePropertyMappingConfigurationFromRequest($this->request, $this->arguments); - } catch (InvalidArgumentForHashGenerationException|InvalidHashException $e) { - $message = $this->throwableStorage->logThrowable($e); - $this->logger->notice('Property mapping configuration failed due to HMAC errors. ' . $message, LogEnvironment::fromMethodName(__METHOD__)); - $this->throwStatus(400, null, 'Invalid HMAC submitted'); - } + + $this->mvcPropertyMappingConfigurationService->initializePropertyMappingConfigurationFromRequest($this->request, $this->arguments); try { $this->mapRequestArgumentsToControllerArguments();