Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow neon_superuser to create event triggers #8808

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

knizhnik
Copy link
Contributor

@knizhnik knizhnik commented Aug 22, 2024

Problem

Only superuser is allows in Postgres to create event triggers.

See #7570

Summary of changes

Postgres submodules:
neondatabase/postgres#475
neondatabase/postgres#476
neondatabase/postgres#477

Allow creation of event triggers to neon_superuser

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@knizhnik knizhnik requested a review from a team as a code owner August 22, 2024 19:32
@knizhnik knizhnik requested a review from MMeent August 22, 2024 19:32
@skyzh
Copy link
Member

skyzh commented Aug 22, 2024

the Postgres submodule seems to have 200+ files updated...? probably you're not on the right branch :(

Copy link

github-actions bot commented Aug 22, 2024

3759 tests run: 3653 passed, 0 failed, 106 skipped (full report)


Flaky tests (1)

Postgres 16

Code coverage* (full report)

  • functions: 32.4% (7256 of 22397 functions)
  • lines: 50.5% (58801 of 116545 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6a032c8 at 2024-08-23T19:01:27.798Z :recycle:

@knizhnik knizhnik force-pushed the allow_event_triggers_for_neon_superuser branch from 2332d67 to 1be6a59 Compare August 23, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants