Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deletion executor <-> upload queue race #9859

Open
skyzh opened this issue Nov 22, 2024 · 1 comment
Open

deletion executor <-> upload queue race #9859

skyzh opened this issue Nov 22, 2024 · 1 comment
Assignees
Labels
t/bug Issue Type: Bug

Comments

@skyzh
Copy link
Member

skyzh commented Nov 22, 2024

as yet another observation at #9844, deletion that gets persisted in the deletion list might be executed after tenant reattach, and we should ensure uploads of the same file happen after it.

@skyzh skyzh added the t/bug Issue Type: Bug label Nov 22, 2024
@skyzh skyzh self-assigned this Nov 22, 2024
@jcsp
Copy link
Collaborator

jcsp commented Nov 25, 2024

I think the fix here is going to be to avoid re-using the same generation, rather than trying to remember this stuff across Tenant lifetimes. This might be pretty simple for ancestor branch detach if we make the detach API carry a new generation to be used in the tenant constructed after restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/bug Issue Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants