Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inaccurate s3 mentions from the code #5772

Open
arpad-m opened this issue Nov 2, 2023 · 0 comments
Open

Remove inaccurate s3 mentions from the code #5772

arpad-m opened this issue Nov 2, 2023 · 0 comments
Labels
c/storage/pageserver Component: storage: pageserver c/storage/scrubber Component: s3_scrubber

Comments

@arpad-m
Copy link
Member

arpad-m commented Nov 2, 2023

Related to #5567, I wouldn't say it's a hard blocker though as it only affects internal parts.

There is log messages/error messages in the code of the pageserver, s3 scrubber etc that mention S3. But with azure blob storage present (added by #5546), these messages are not accurate any more: they can also be about S3. We should find an alternative that is not too long, but more accurately reflects that we interact with some remote storage, whether it's S3, azure blobs, or the local file system. Then we should migrate the log lines to that alternative.

Obviously, code that is still specific to S3, e.g. due to directly interacting with the AWS SDK instead of going through the remote storage abstraction can still mention S3. This is only about the ones where the use is not accurate.

@arpad-m arpad-m added the c/storage/pageserver Component: storage: pageserver label Nov 2, 2023
@jcsp jcsp added the c/storage/scrubber Component: s3_scrubber label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/pageserver Component: storage: pageserver c/storage/scrubber Component: s3_scrubber
Projects
None yet
Development

No branches or pull requests

2 participants