New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GPL decoder unidecode #494

Open

rsxdalv opened this issue Jun 28, 2023 · 1 comment

Contributor

rsxdalv commented Jun 28, 2023

Replacing this line with an alternative would ensure that the entire project is GPL free.

https://github.com/neonbjb/tortoise-tts/blob/main/tortoise/utils/tokenizer.py#L124

Here are some examples of alternatives:

https://stackoverflow.com/a/1211102

https://stackoverflow.com/questions/1207457/convert-a-unicode-string-to-a-string-in-python-containing-extra-symbols/1207479#1207479

Another approach would be to make it an optional dependency with a fallback. While not ideal it would be better than the current situation.

Owner

neonbjb commented Jun 29, 2023

Happy to approve a PR that makes this replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment