Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Improving/changing the spell checker leads to tests breaking, implementation changing #79

Open
neomatrix369 opened this issue Mar 13, 2023 · 3 comments
Labels
2. medium-priority Good if it can be attended to be soon, but not urgent enough bug Something isn't working high-level feature(s)

Comments

@neomatrix369
Copy link
Owner

neomatrix369 commented Mar 13, 2023

Describe the bug

On the back of the PR #71 which was reverted from master due to breaking changes, would be best to review, and fix either implement/tests or both and merge to master.

To Reproduce

Clone the branch related to PR #71 and run all the tests.

Version information:

Version 0.0.3 - no other aspects are linked to it

Additional context

The steps would be following in order to apply and test the improvements to the spell checker:

  • get latest changes on local master
  • branch from master for spell checker changes
  • run all the tests with ./test-coverage.sh tests slow-tests
  • apply the spell checker changes as applied previously via PR Spelling checker has been modified #71
  • run all the tests with ./test-coverage.sh tests slow-tests
  • fix tests such that the tests are passing for the right reasons
  • create Pull Request and follow guidelines (GA on PR should indicate if the changes are good or not)

PR #71 was reverted via PR #75.

@neomatrix369 neomatrix369 added the bug Something isn't working label Mar 13, 2023
@neomatrix369 neomatrix369 added 2. medium-priority Good if it can be attended to be soon, but not urgent enough high-level feature(s) labels Mar 13, 2023
@neomatrix369
Copy link
Owner Author

@bitanb1999 take a look at this issue and start thinking about it when you get a chance, it will need some checking and verifying throughout the process.

@bitanb1999
Copy link
Contributor

@bitanb1999 take a look at this issue and start thinking about it when you get a chance, it will need some checking and verifying throughout the process.

Sure! Will look into it!

@bitanb1999
Copy link
Contributor

Re-looking into this @neomatrix369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. medium-priority Good if it can be attended to be soon, but not urgent enough bug Something isn't working high-level feature(s)
Projects
None yet
Development

No branches or pull requests

2 participants