From de60a51faacdd2b0da25837bbb7424c64c8a8e55 Mon Sep 17 00:00:00 2001
From: Dmitriy Tverdiakov <dmitriy.tverdiakov@neo4j.com>
Date: Wed, 22 Feb 2023 16:08:19 +0000
Subject: [PATCH] Update clirr configuration to check against previous version

The `clirr-maven-plugin` configuration has been checking against `4.0.0` driver version for significant time. While it is useful in general, comparing against previous driver version (the default setting) has a benefit of making removals of public methods more visible in reviews.
---
 bundle/pom.xml                       |  2 +-
 driver/clirr-ignored-differences.xml |  6 ++++++
 driver/pom.xml                       | 16 ++++++++--------
 examples/pom.xml                     |  2 +-
 pom.xml                              |  2 +-
 testkit-backend/pom.xml              |  2 +-
 testkit-tests/pom.xml                |  2 +-
 7 files changed, 19 insertions(+), 13 deletions(-)

diff --git a/bundle/pom.xml b/bundle/pom.xml
index 79d2a1b508..6a06769443 100644
--- a/bundle/pom.xml
+++ b/bundle/pom.xml
@@ -6,7 +6,7 @@
   <parent>
     <groupId>org.neo4j.driver</groupId>
     <artifactId>neo4j-java-driver-parent</artifactId>
-    <version>5.5-SNAPSHOT</version>
+    <version>5.6-SNAPSHOT</version>
     <relativePath>..</relativePath>
   </parent>
 
diff --git a/driver/clirr-ignored-differences.xml b/driver/clirr-ignored-differences.xml
index aac03eace6..59b51ea0af 100644
--- a/driver/clirr-ignored-differences.xml
+++ b/driver/clirr-ignored-differences.xml
@@ -421,6 +421,12 @@
         <method>org.neo4j.driver.BookmarkManager queryBookmarkManager()</method>
     </difference>
 
+    <difference>
+        <className>org/neo4j/driver/Driver</className>
+        <differenceType>7002</differenceType>
+        <method>org.neo4j.driver.BookmarkManager queryBookmarkManager()</method>
+    </difference>
+
     <difference>
         <className>org/neo4j/driver/Driver</className>
         <differenceType>7012</differenceType>
diff --git a/driver/pom.xml b/driver/pom.xml
index 5f1a767d2b..3f22399600 100644
--- a/driver/pom.xml
+++ b/driver/pom.xml
@@ -6,7 +6,7 @@
   <parent>
     <groupId>org.neo4j.driver</groupId>
     <artifactId>neo4j-java-driver-parent</artifactId>
-    <version>5.5-SNAPSHOT</version>
+    <version>5.6-SNAPSHOT</version>
   </parent>
 
   <artifactId>neo4j-java-driver</artifactId>
@@ -164,17 +164,17 @@
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>clirr-maven-plugin</artifactId>
           <configuration>
-            <comparisonArtifacts>
-              <comparisonArtifact>
-                <groupId>org.neo4j.driver</groupId>
-                <artifactId>neo4j-java-driver</artifactId>
-                <version>4.0.0</version>
-              </comparisonArtifact>
-            </comparisonArtifacts>
             <classesDirectory>${api.classes.directory}</classesDirectory>
             <excludes>org/neo4j/driver/internal/**</excludes>
             <ignoredDifferencesFile>clirr-ignored-differences.xml</ignoredDifferencesFile>
           </configuration>
+          <dependencies>
+            <dependency>
+              <groupId>org.apache.bcel</groupId>
+              <artifactId>bcel</artifactId>
+              <version>6.7.0</version>
+            </dependency>
+          </dependencies>
         </plugin>
       </plugins>
     </pluginManagement>
diff --git a/examples/pom.xml b/examples/pom.xml
index f1749c7270..35260d3ca7 100644
--- a/examples/pom.xml
+++ b/examples/pom.xml
@@ -6,7 +6,7 @@
   <parent>
     <groupId>org.neo4j.driver</groupId>
     <artifactId>neo4j-java-driver-parent</artifactId>
-    <version>5.5-SNAPSHOT</version>
+    <version>5.6-SNAPSHOT</version>
   </parent>
 
   <groupId>org.neo4j.doc.driver</groupId>
diff --git a/pom.xml b/pom.xml
index 55be848d84..8649e97720 100644
--- a/pom.xml
+++ b/pom.xml
@@ -5,7 +5,7 @@
 
   <groupId>org.neo4j.driver</groupId>
   <artifactId>neo4j-java-driver-parent</artifactId>
-  <version>5.5-SNAPSHOT</version>
+  <version>5.6-SNAPSHOT</version>
 
   <packaging>pom</packaging>
   <name>Neo4j Java Driver Project</name>
diff --git a/testkit-backend/pom.xml b/testkit-backend/pom.xml
index 548b7383db..a7e0358641 100644
--- a/testkit-backend/pom.xml
+++ b/testkit-backend/pom.xml
@@ -7,7 +7,7 @@
     <parent>
         <artifactId>neo4j-java-driver-parent</artifactId>
         <groupId>org.neo4j.driver</groupId>
-        <version>5.5-SNAPSHOT</version>
+        <version>5.6-SNAPSHOT</version>
     </parent>
 
     <artifactId>testkit-backend</artifactId>
diff --git a/testkit-tests/pom.xml b/testkit-tests/pom.xml
index c6a6ac77ae..d4c879bfc8 100644
--- a/testkit-tests/pom.xml
+++ b/testkit-tests/pom.xml
@@ -6,7 +6,7 @@
     <parent>
         <groupId>org.neo4j.driver</groupId>
         <artifactId>neo4j-java-driver-parent</artifactId>
-        <version>5.5-SNAPSHOT</version>
+        <version>5.6-SNAPSHOT</version>
         <relativePath>..</relativePath>
     </parent>