Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated update input #5630

Merged
merged 14 commits into from
Oct 10, 2024
Merged

Remove deprecated update input #5630

merged 14 commits into from
Oct 10, 2024

Conversation

angrykoala
Copy link
Member

Description

Remove deprecated top level arguments for nested operations in mutations:

  • create
  • delete
  • connect
  • disconnect
  • connectOrCreate

For example, the following is no longer valid:

invalid

mutation UpdatePeople {
    updatePeople(create: { movies: { node: { title: "The Good" } } }) {
        people {
            name
        }
    }
}

valid

mutation UpdatePeople {
    updatePeople(update: { movies: { create: { node: { title: "The Good" } } } }) {
        people {
            name
        }
    }
}

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 31d83dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@neo4j/graphql Major
@neo4j/graphql-amqp-subscriptions-engine Major
neo-place Patch
apollo-subscriptions-server Patch
yoga-subscriptions-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I won't comment on every one, but any reason you opted to remove some of these tests instead of updating them?

@angrykoala
Copy link
Member Author

Lots of those are redundant, either because we had duplicate tests, or because now that we have a single path, the other was already tested.

@angrykoala angrykoala force-pushed the remove-deprecated-update-input branch from 7b9fa90 to 31d83dc Compare October 10, 2024 14:13
@angrykoala angrykoala merged commit b13c19e into 6.x Oct 10, 2024
43 checks passed
@angrykoala angrykoala deleted the remove-deprecated-update-input branch October 10, 2024 14:23
This was referenced Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants