Custom Cypher and Union return type - preserve array return #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recent changes to custom Cypher made it so that
expectMultipleReturnsofapoc.cypher.runFirstColumnis only set totrueif a node match was found for the return type. Union return types did not meet this requirement, soexpectMultipleReturnswas set tofalseand only 1 record would ever be returned.It should be clarified that Union returns for custom Cypher will not have relationships automatically projected, and this will only change when we work on querying Unions/Interfaces from the root Query type.
Issue
#315
Checklist
The following requirements should have been met (depending on the changes in the branch):