Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated label and additonalLabels arguments #2834

Merged
merged 10 commits into from
Feb 6, 2023

Conversation

a-alle
Copy link
Contributor

@a-alle a-alle commented Feb 3, 2023

Description

Remove deprecated label and additonalLabels arguments from the @node directive: in the library and introspector.
Depends on #2825 to be merged into dev.

Complexity

Complexity: Low

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2023

🦋 Changeset detected

Latest commit: e02edd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@neo4j/introspector Major
@neo4j/graphql Major
@neo4j/graphql-toolbox Patch
@neo4j/graphql-ogm Major
neo-place Patch
neo-push-server Patch
apollo-suscriptions-server Patch
yoga-subscriptions-server Patch
@neo4j/graphql-plugin-subscriptions-amqp Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Feb 3, 2023

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3403 3403 33 41 1134
aggregations.NestedAggregation 13514 13514 90 196 2174
aggregations.AggregationWithWhere 10942 10942 78 165 2174
aggregations.NestedCountFromMovieToActors 8694 8694 57 82 2174
aggregations.NestedCountFromActorsToMovie 8900 8900 71 77 2174
aggregations.DeeplyNestedCount 10054408 10054408 4444 4132 2008534
batch-create.BatchCreate 3600 3600 94 114 600
connect.createAndConnect 12419 12419 239 237 3003
connections.Connection 13042 13042 105 248 2174
connections.NestedConnection 33883 33883 105 235 4516
connections.ConnectionWithSort 2277 2277 58 92 1040
connections.ConnectionWithSortAndCypher 14278 14278 86 130 2174
create.SimpleMutation 6 6 34 35 1
cypher-directive.TopLevelMutationDirective 1135 1135 30 49 1134
delete.SimpleDelete 18361 18361 250 243 1040
delete.NestedDeleteInUpdate 16779 16779 235 167 2040
query.SimpleQuery 14120 14120 85 95 2174
query.QueryWhere 8658 8658 35 39 2160
query.SimpleQueryWithNestedWhere 8829 8829 64 55 2160
query.Nested 10084290 10084290 10249 9977 2008534
query.NestedWithFilter 37172 37172 121 115 4511
query.OrFilterOnRelationships 36414 36600 200 193 1704
query.OrFilterOnRelationshipsAndNested 30319 30321 237 241 1704
query.QueryWithNestedIn 12239 12239 60 60 1180
query.NestedConnectionWhere 8794 8794 101 70 2174
query.DeeplyNestedConnectionWhere 8898 8898 109 122 2174
query.DeeplyNestedWithRelationshipFilters 6251 6251 125 141 1134
query.DeeplyNestedWithRelationshipSingleFilters 15438 15438 83 100 2174
query.Fulltext 96 96 29 28 16
query.FulltextWithNestedQuery 571 571 42 45 84
sorting.SortMultipleTypes 2493 2493 64 69 1040
sorting.SortMultipleTypesWithCypherWithCypher 13407 13407 95 95 2174
sorting.SortOnNestedFields 13042 13042 115 80 2174
sorting.SortDeeplyNestedFields 38965 38965 170 177 4516
sorting.SortWithTopLevelCypher 14120 14120 50 65 2174
unions.SimpleUnionQuery 321 321 58 78 35
unions.SimpleUnionQueryWithMissingFields 293 293 54 59 35
unions.NestedUnion 398553 398553 276 327 33033
unions.NestedUnionWithMissingFields 372527 372527 283 319 33033
update.NestedUpdate 2119 2119 42 48 1040

Old Schema Generation: 28.052s
Schema Generation: 28.480s

Copy link
Contributor

@MacondoExpress MacondoExpress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would just remove the last occurrences of label and additionalLabels.

packages/graphql/src/classes/Node.ts Show resolved Hide resolved
packages/graphql/src/classes/NodeDirective.ts Outdated Show resolved Hide resolved
@a-alle a-alle merged commit ccce9ce into neo4j:4.0.0 Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants