-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft NEP 26 and Draft NEP 27: New NEPs describing onNEPXXPayment callbacks #169
Conversation
Fixes neo-project#168. Signed-off-by: Roman Khimov <[email protected]>
Seems good to me, maybe we can use NEP-117 and NEP-111, something related to the parent? or we need to be consecutives? |
Huh, we don’t have to. Seems that’s exactly the case of special numbers:
|
Burguer neo? |
Link? We can add everything we have, I think it's pretty popular. |
|
Signed-off-by: Roman Khimov <[email protected]>
bNEO uses it and we can't say it's wrong. Signed-off-by: Roman Khimov <[email protected]>
Mediawiki is not Markdown. Signed-off-by: Roman Khimov <[email protected]>
Added bNEO and also added a note on ASSERTs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also good to me, need to update status and add NEP numbers (I'm not allowed to resolve conversations in this repo).
@roman-khimov Could you update status and add NEP numbers? No.25 and No.26 will be OK. |
Co-authored-by: Jimmy <[email protected]>
Co-authored-by: Jimmy <[email protected]>
Co-authored-by: Jimmy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roman-khimov, the details look good to me, apart for the first motivation paragraph that I will comment there.
On the other hand, I thought there were additional recommendation in the semantics.
In such case I think you can do an append to NEO-11 or NEP-27.
This does not necessary need a number. There is no sense to me.
@vncoelho YOU DO NOT CHANGE ANY EXISTING NEP. ITS NEP, A STANDARD, NOT SOME DOCUMENT YOU CAN UPDATE AND UPGRADE FROM TIME TO TIME. |
In my opinion it is a New Informational NEP or a documentation issue. Do we have any place to classify the NEPs? For example: https://eips.ethereum.org/informational |
|
Sorry it was not motivational part. It was below it. I already left some comments |
Add a bit more details, signify the need for script hash check. Signed-off-by: Roman Khimov <[email protected]>
@roman-khimov Please update readme. We can merge this first incase approvals are reverted. @shargon |
Please add more implementation references.