[Fixed] Dotnet version for DevContainer

[cschuchardt88]

Description

The version of dotnet was wrong for the devcontainer.

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Locally

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[vncoelho]

Good!
now global does not need to be modified locally.

Can you add the link to the list of images?
Then we can follow easily next update.

[cschuchardt88]

images and what link?

[Jim8y]

lets revert back to dotnet 8 please, cant use dotnet 9 for now.

[cschuchardt88]

That is unnecessary, a update coming out next month that fixes the issues. Unless we have a new release coming out this month. then no reason to revert it.

lets revert back to dotnet 8 please, cant use dotnet 9 for now.

What can't you use? If the problem is neo-devpack-dotnet then revert for that project. No need to revert neo repo. You can also fix the issue, if you compile the neo.vm to dotnet standard then import it. Instead of building as dotnet.

Plus I warned you all and didn't listen to me. So now I'm not going back to dotnet 8.0.

[vncoelho]

I think that if there is a release coming as @cschuchardt88 mentioned you should revert to 8.0, otherwise, let's keep fixing this one.

Revert to dotnet 8 should be considered.

[AnnaShaleva]

You can also fix the issue, if you compile the neo.vm to dotnet standard then import it.

But are you sure that the neo core itself is not affected by this bug in dotnet 9? Because BigInteger arithmetic is widely used in the core (not only in VM).

[cschuchardt88]

But are you sure that the neo core itself is not affected by this bug in dotnet 9? Because BigInteger arithmetic is widely used in the core (not only in VM).

Only thing that isnt working is GetBitLength or invalid bit length, and in the neo.vm is the really the only the place this happens.

[AnnaShaleva]

and in the neo.vm is the really the only the place this happens.

If it's true, then I'm not against of this PR.

But in general I'd expect the same dotnet version to be used within the whole stack. It's the way how we build software in nspcc-dev org, and it's a good practice, the whole stack has the same minimum required Go version, so I'd expect the same from the neo-project org. So if we take a decision to revert to dotnet 8, then every project should be reverted.

[cschuchardt88]

and in the neo.vm is the really the only the place this happens.

If it's true, then I'm not against of this PR.

But in general I'd expect the same dotnet version to be used within the whole stack. It's the way how we build software in nspcc-dev org, and it's a good practice, the whole stack has the same minimum required Go version, so I'd expect the same from the neo-project org. So if we take a decision to revert to dotnet 8, then every project should be reverted.

Looks like elliptical curve uses GetBitLength too. However all test are showing the correct output. So i dont know what neo-devpack is doing to have trouble with BigInteger.