Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] GetStorage for ContractState #3615

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cschuchardt88
Copy link
Member

Description

Get contract storage for a given contract. Returns all storage keys and values for StorageMap.

Change Log

  • Added GetStorage extension methods

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • TestGetStorage

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a command to call this method in the client? otherwise I don't see a real use case

@Jim8y
Copy link
Contributor

Jim8y commented Dec 12, 2024

Could you add a command to call this method in the client? otherwise I don't see a real use case

This pr considers the core as an SKD of neo that can be used by other parties. Not necessarily being used by cli. And i think the core actually has that assumption, otherwise we dont need to support netstandard.

@cschuchardt88
Copy link
Member Author

Could you add a command to call this method in the client? otherwise I don't see a real use case

in a different pr, I could add another command in neo-cli.

@Jim8y Jim8y requested review from AnnaShaleva and shargon December 13, 2024 03:31
@nan01ab
Copy link
Contributor

nan01ab commented Dec 13, 2024

Could you add a command to call this method in the client? otherwise I don't see a real use case

This pr considers the core as an SKD of neo that can be used by other parties. Not necessarily being used by cli. And i think the core actually has that assumption, otherwise we dont need to support netstandard.

SDK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants