-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remove] obsolete WsServer
#3582
[Remove] obsolete WsServer
#3582
Conversation
/// Indicates that the node is listening on a WebSocket port. | ||
/// </summary> | ||
[Obsolete] | ||
WsServer = 0x02, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's correct to remove it like this. Technically it existed in the P2P protocol, so at least the number should be kept as reserved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ObsoleteWsServer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can always repurpose it in the future. Reserving it says to me that it still WsServer
or active.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not agree, either we should implement it or w should remove it, having somthing in the core that is not implemented (and is not documented) is not a good practice, might exist in the past by mistake, but should be fixed, there is no hardfork for this, should not bother.
I have to say that there are too many things in the neo core that is not documented, not commented, not explained, not in proposal, the only way we learn it is by reading the code, but this wss is even a trap of implementation, it exists, but not work, as chris said "Reserving it says to me that it still WsServer or active.". only very few of us know how they works, this is by no means a good practice.
This reverts commit 849b2c8. Co-authored-by: Shargon <[email protected]>
Change Log
NodeCapabilityType
.NodeCapabilityType.WsServer
Type of change
How Has This Been Tested?
Size_Get
DeserializeAndSerialize
Test Configuration:
Checklist: