-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check ABI for notifications #2810
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e88062f
Check ABI for notifications
erikzhang f0b3071
Merge branch 'master' into check-abi-for-notifications
erikzhang c7e9ced
Merge branch 'master' into check-abi-for-notifications
shargon 95ee47e
Merge branch 'master' into check-abi-for-notifications
shargon a426a29
Merge branch 'master' into check-abi-for-notifications
vncoelho e3db758
Merge branch 'master' into check-abi-for-notifications
shargon 95b9983
Merge branch 'master' into check-abi-for-notifications
vncoelho 8cb741b
Merge branch 'master' into check-abi-for-notifications
shargon 75829a9
Patch checkabi (#2884)
Ashuaidehao 080695d
Merge branch 'master' into check-abi-for-notifications
shargon b812394
Merge branch 'master' into check-abi-for-notifications
Jim8y 93b4126
Check UTF8 string
shargon be2ef40
Cleaner way
shargon 780103a
Fix Buffer
shargon 3f10c96
Update src/Neo/SmartContract/ApplicationEngine.Runtime.cs
Jim8y File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to have some additional checks for the
String
type? The way it is now it's absolutely the same asByteArray
, maybe some differentiation can be useful like ifString
could only contain valid UTF-8 byte sequence.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shargon, how about this additional check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnnaShaleva Done