Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProtocolSettings.Default.ValidatorsCount not initialized correctly from StandbyValidators #1769

Closed
devhawk opened this issue Jul 15, 2020 · 0 comments · Fixed by #1770
Closed

ProtocolSettings.Default.ValidatorsCount not initialized correctly from StandbyValidators #1769

devhawk opened this issue Jul 15, 2020 · 0 comments · Fixed by #1770

Comments

@devhawk
Copy link
Contributor

devhawk commented Jul 15, 2020

Describe the bug
ProtocolSettings ctor initializes StandbyCommittee property from StandbyValidators config section, but does not correctly set the validator count value

To Reproduce
Steps to reproduce the behavior:
Create a private net with 1 or 4 standby validator nodes but do not set validatorsCount in protocol.json

Expected behavior
ProtocolSettings.Default.ValidatorsCount should equal the number of standby validators

Actual Behavior
Blockchain initialization of StandbyValidators field throws an exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix protocol.json Tommo-L/neo
1 participant
@devhawk