Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SALT to DB3 wallets #1395

Closed
shargon opened this issue Jan 3, 2020 · 0 comments · Fixed by #1444
Closed

Add SALT to DB3 wallets #1395

shargon opened this issue Jan 3, 2020 · 0 comments · Fixed by #1444
Labels
Discussion Initial issue state - proposed but not yet accepted

Comments

@shargon
Copy link
Member

shargon commented Jan 3, 2020

Summary or problem description
DB3 wallets does not use any salt for hashing. This makes easier for attackers to pre-compute the hash value using dictionary attack techniques such as rainbow tables.

Do you have any solution you want to propose?
Concat the IV and double SHA256

Neo Version

  • Neo 2
  • Neo 3

Where in the software does this update applies to?

  • Wallet
@shargon shargon added the Discussion Initial issue state - proposed but not yet accepted label Jan 3, 2020
@shargon shargon mentioned this issue Jan 3, 2020
Closed
@shargon shargon mentioned this issue Feb 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Salt and NEP2 to db3 wallet shargon/neo
Add SALT to db3 wallet neo-project/neo
1 participant
@shargon