Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Exception message about consensus logs can be written into error.log #1245

Closed
cloud8little opened this issue Nov 15, 2019 · 2 comments · Fixed by #1623
Closed
Labels
Cosmetic Type - Changes that improve user experience without affecting current functionality. Housekeeping Small enhancements that need to be done in order to keep the project organised Ready-to-Implement Issue state: Ready to be implemented or implementation in progress

Comments

@cloud8little
Copy link
Contributor

Summary or problem description
Exception message about consensus logs can be written into error.log

Do you have any solution you want to propose?
Recently i've run several tests about consensus service, and found that the exception logs are not written to the file error.log, and fortunately I use screen to recover the session so the error logs can be found out. Even though you can use "> xx.log" to log this, this requires you add it when you start the service.

Where in the software does this update applies to?

  • CLI

neo-cli: #470
neo: ##1150

Exception like this, currently wallet format error will be logged, but consensus service error won't .
4281573804642_ pic_hd
4301573806271_ pic_hd

@cloud8little cloud8little added the Discussion Initial issue state - proposed but not yet accepted label Nov 15, 2019
@shargon
Copy link
Member

shargon commented Nov 15, 2019

@cloud8little Thanks so much! we will improve a lot of with these tests :)

Now the exceptions are captured by akka

https://github.com/neo-project/neo-cli/blob/8c6de106094a8894c7be2c19768697f9afef774f/neo-cli/Program.cs#L13

So... I think that we need to call this method when akka print the log.

@shargon
Copy link
Member

shargon commented Nov 16, 2019

@neo-project/ngd-shanghai do you know if we can merge AppDomain.CurrentDomain.UnhandledException and akka logging in the same method?

@lock9 lock9 added Cosmetic Type - Changes that improve user experience without affecting current functionality. Housekeeping Small enhancements that need to be done in order to keep the project organised Ready-to-Implement Issue state: Ready to be implemented or implementation in progress and removed Discussion Initial issue state - proposed but not yet accepted labels Nov 17, 2019
@shargon shargon reopened this May 1, 2020
@shargon shargon closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cosmetic Type - Changes that improve user experience without affecting current functionality. Housekeeping Small enhancements that need to be done in order to keep the project organised Ready-to-Implement Issue state: Ready to be implemented or implementation in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants