Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

NULL Opcode compatibility #215

Closed
shargon opened this issue Oct 19, 2019 · 3 comments · Fixed by neo-project/neo-devpack-dotnet#115
Closed

NULL Opcode compatibility #215

shargon opened this issue Oct 19, 2019 · 3 comments · Fixed by neo-project/neo-devpack-dotnet#115
Labels

Comments

@shargon
Copy link
Member

shargon commented Oct 19, 2019

Currently with the last changes of NEO-VM, the null's checks doesn't work as expected and the compiler need to be updated according to this changes

The following code

image

Is compiled as (ILCode)

image

But the Ceq opcode is compiled as

image

So I think that the VM need to be updated in order to accept ' null' too in NUMEQUAL

Fixes: neo-project/neo-devpack-dotnet#115 #214

@erikzhang
Copy link
Member

@lightszero Can you check it?

@shargon
Copy link
Member Author

shargon commented Oct 19, 2019

@lightszero you have the unit test and changes for it here neo-project/neo-devpack-dotnet#115 , Please review it :)

@lightszero
Copy link
Member

add some fix in neo-project/neo-devpack-dotnet#115 ,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants