Update deploy command following NEO3 schema

[shargon]

Close neo-project/neo-devpack-dotnet#91
Require neo-project/neo-devpack-dotnet#109
Related to neo-project/neo-devpack-dotnet#91

Should follow this logic
https://github.com/neo-project/neo/blob/e1fdde307153879f0a7ae64bd3e11d042284896e/neo/SmartContract/InteropService.NEO.cs#L248

[superboyiii]

Require neo-project/neo-devpack-dotnet#109
Related to neo-project/neo-devpack-dotnet#91

Should follow this logic
https://github.com/neo-project/neo/blob/e1fdde307153879f0a7ae64bd3e11d042284896e/neo/SmartContract/InteropService.NEO.cs#L248

Great! Let me have a look.

[superboyiii]

@shargon Hi, Shargon, I've made a test based on my simple sc. The content is：

using System;


namespace Neo.SmartContract
{
    public class ICO_Template : Framework.SmartContract
    {
        //Token Settings
        public static string Name() => "ZZH";
        public static string Symbol() => "ZZH";


        public static Object Main(string operation, params object[] args)
        {
            if (Runtime.Trigger == TriggerType.Application)
            {

                if (operation == "name") return Name();
                if (operation == "symbol") return Symbol();

            }
            return false;
        }
    }
}

It was compiled successfully within neon.exe

You could see there're manifest in the root path.

Then I deploy it on neo-cli-3.0.0-preview1, meet an issue on invoking ContractMethodDescriptor.

[shargon]

Thanks for the test, i will review it

[shargon]

You are right, we need some changes included in neo-project/neo-devpack-dotnet#93 , i will copy these fixes

[vncoelho]

Great to see how simpler is becomes!

[vncoelho]

Is this needed, @shargon?

The compiler is going to be different.
Maybe we can just say that the syscall is not valid. I think there is not need to really explicit that it is NEO2.

[superboyiii]

@vncoelho Hey, my friend, since we've not deployed a new nuget for NEO3 SmartContract Framework, and the NEO3 one is also using the version number 2.9.3, it can make developers greatly confused, including me, hahaha. So I think this error message is necessary because if you're using the NEO2 nuget of Framework 2.9.3 to deploy a sc on NEO3, it's incompatible.

[shargon]

Yes, If you use the old version of SmartContract.Framework, you can get a wrong NEF, so I think that this checks could be very useful. Is possible that some invalid contract pass, it is a basic filter for prevent some human errors.

[lock9]

@shargon we just have to replace ".nef" with "manifest.json", or equivalent (I don't recall the exact file extension)

[shargon]

Is not the expected behavior , tell me one linux command that works as you said?

[lock9]

@shargon all of them, you tell me a program that you have to point to all files 😂
What if it is optional? If you don't send any, it will just use the same file name with a different extension?

For example make, docker build and many others assume the filename. This is a very common pattern

[shargon]

Then i don't understand you very well, you are asking for a file (first parameter) and name (the second) ? give me an example please

[shargon]

@lock9 please review it again.

[superboyiii]

I'll let @nicolegys to have a test.

[lock9]

@shargon

Maybe the manifest is broken? I used the latest master and you can see that the file exists.

EDIT: It worked when I added 'static' to the methods, maybe it should have blocked it at compilation time?

[lock9]

It is working.
Thanks @shargon!

[nicolegys]

Successfully deploy a smart contract without manifest.json

[nicolegys]

In debug mode, it will throw an exception when I deploy a NEO2 smartContract.

But it will only return 'error' when I use a release version neo-cli.

Because of this:

Should we add 'Console.WriteLine' directly instead of throwing an exception?

[shargon]

we can remove the Debug directive

[lock9]

Thanks Shargon

[superboyiii]

Tested. It works effectively.