Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UT for ImportBlocks #80

Open
vncoelho opened this issue Apr 10, 2019 · 2 comments
Open

UT for ImportBlocks #80

vncoelho opened this issue Apr 10, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@vncoelho
Copy link
Member

I am thinking about an UT for Import Blocks.

What do you think about an isolated docker file, integrated with Travis, that initializes neo-cli and sync some blocks?

Maybe we can also design it to avoid to be executed if files from ImportBlocks.cs were not modified.
@lock9 lock9 added enhancement New feature or request low-priority and removed discussion labels Jul 23, 2019
@lock9
Copy link
Contributor

lock9 commented Jul 23, 2019

This is important and required. I just added "low priority" to this because I believe all migration issues will be left for Q4. @vncoelho feel free to change it if you think this was a mistake! Thanks

@shargon
Copy link
Member

shargon commented Sep 11, 2019

This could help with #129 so i will remove the low-priority flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shargon @erikzhang @vncoelho @lock9