Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RpcServer: partial Signers unmarshalling #423

Closed
AnnaShaleva opened this issue Dec 11, 2020 · 0 comments · Fixed by #436
Closed

RpcServer: partial Signers unmarshalling #423

AnnaShaleva opened this issue Dec 11, 2020 · 0 comments · Fixed by #436

Comments

@AnnaShaleva
Copy link
Member

Describe the bug
Both GetInvokeResult and GetVerificationResult methods use signers.Witnesses field (here and here), but this field is always null, because it is never unmarshalled from JSON (see SignersFromJSON method, it unmarshals signers only and does not pay attention to witnesses).

This issue might not be so critical for invokefunction and invokescript RPC calls, but it is important for the new invokecontractverify RPC call.

Expected behavior
Signer's witnesses should be taken into account during invokefunction, invokescript and invokecontractverify RPC-calls handling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sign the transaction in the InvokeContractVerify method chenzhitong/neo-modules
1 participant
@AnnaShaleva