Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TransactionManager to support magic parameter #343

Closed
devhawk opened this issue Sep 8, 2020 · 2 comments
Closed

Update TransactionManager to support magic parameter #343

devhawk opened this issue Sep 8, 2020 · 2 comments

Comments

@devhawk
Copy link
Contributor

devhawk commented Sep 8, 2020

Summary or problem description
neo-project/neo#1902 added overload of IVerifiable.Sign that takes an explicit magic value. Transaction Manager needs to be updated to take an optional magic value parameter to its constructor (defaulting to Protocol.Default.Magic if not provided) that is in turn passed to Tx.Sign in TransactionManager.Sign[Async]

Should probably wait until after #335 is merged before doing this

Where in the software does this update applies to?
RPC

@superboyiii
Copy link
Member

Summary or problem description
neo-project/neo#1902 added overload of IVerifiable.Sign that takes an explicit magic value. Transaction Manager needs to be updated to take an optional magic value parameter to its constructor (defaulting to Protocol.Default.Magic if not provided) that is in turn passed to Tx.Sign in TransactionManager.Sign[Async]

Should probably wait until after #335 is merged before doing this

Where in the software does this update applies to?
RPC

#335 is merged. Now we can do this.

@devhawk
Copy link
Contributor Author

devhawk commented Oct 15, 2020

This was fixed as part of #335: #335 (comment)

@shargon shargon closed this as completed Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants