Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check dotnet format in travis #94

Merged
merged 8 commits into from
Aug 26, 2019
Merged

Check dotnet format in travis #94

merged 8 commits into from
Aug 26, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Aug 25, 2019

This will prevent to push any format error

Related to neo-project/neo#982

@shargon
Check dotnet format in travis
2bdc540 
This will prevent to push any format error

Related to neo-project/neo#982
@shargon
Copy link
Member Author

shargon commented Aug 25, 2019

@igormcoelho it seems that CRLF is checked here, isn't it?

@igormcoelho
Copy link
Contributor

Let's format this before 93... it's too complicated to review. This code was never properly indented 😂

@igormcoelho
Copy link
Contributor

@shargon can you reopen this in your branch? I cannot write over neo directly, I don't know why...

@igormcoelho
Copy link
Contributor

Ok, I created another repo clone with write access here. Let's fix travis before 94, so changes will be much easier to track (compiler is tricky).

@igormcoelho
Copy link
Contributor

Man, this code is so non-formatted... I don't know what to do here. Let's just pass these basic changes for now... and we format it in time perhaps...

igormcoelho
igormcoelho previously approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass, we should merge this ASAP (24hrs and counting).

@shargon
Copy link
Member Author

shargon commented Aug 26, 2019

If tests pass, we should merge this ASAP (24hrs and counting).

image

@shargon
Copy link
Member Author

shargon commented Aug 26, 2019

We should unify in a future the name of the folders across all the projects

@igormcoelho
Copy link
Contributor

Yes.. in fact this one I like more: src and tests. Just a typo causing headache here 😂

@vncoelho
Copy link
Member

image

igormcoelho
igormcoelho approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm positive, tests will pass 💪

vncoelho
vncoelho approved these changes Aug 26, 2019
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shargon
Copy link
Member Author

shargon commented Aug 26, 2019

PASSED!

@vncoelho
Copy link
Member

I will restart travis to be sure it passed. aehuaheuhea ajajaj

@igormcoelho
Copy link
Contributor

double-check is always good precaution 👍
😂

@igormcoelho igormcoelho merged commit b73bd74 into master Aug 26, 2019
@igormcoelho igormcoelho deleted the dotnet-format branch August 26, 2019 18:58
@igormcoelho
Copy link
Contributor

Sorry guys, we need to review 93. This is blocking us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho approved these changes

@igormcoelho igormcoelho igormcoelho approved these changes

@lock9 lock9 Awaiting requested review from lock9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shargon @igormcoelho @vncoelho