Generate default manifest file when compiling

[shargon]

Close #91

Fix ABI issues

@superboyiii This is the expected value for neo-cli

[superboyiii]

Close #91

@superboyiii This is the expected value for neo-cli

Wow, great, Let me test it.

[shargon]

@superboyiii Please, could you try again?

[superboyiii]

@superboyiii Please, could you try again?

Success! But there seems still something wrong on sc execution.

[shargon]

Strange... please, try without if (Runtime.Trigger == TriggerType.Application) or add other return in this else

[lock9]

I decompiled the script deployed and it doesn't look healthy:

Shouldn't it have a "PUSHDATA2" or equivalent? My code can be broken, but I checked it manually and it seems that there is something wrong in the serialization of the smart contract

[shargon]

I will review it

[shargon]

@lock9 This is the deploy or the smartcontract? The deploy script looks good in my test, and the contract was created

[shargon]

The smart contract looks good too

I will review it with a real deploy

[superboyiii]

The smart contract looks good too

I will review it with a real deploy

Yes, you're right. If I remove the Runtime.Trigger, it works well.

[shargon]

Without remove the Trigger it works to me, is the same code you provide me

[shargon]

@superboyiii You are trying with RPC, could you test it by neo-cli?

[superboyiii]

@superboyiii You are trying with RPC, could you test it by neo-cli?

Add the Trigger and invoke it inside neo-cli, still return "".

I'm using SmartContract.Framework 2.9.3.1, is it related to this issue?

[shargon]

Please, send me your nef and manifest file
This is mine.
sc.zip

[superboyiii]

@shargon Yours works well on mine. But I'm not sure which course is different between us. Here's mine.
owen.zip

[shargon]

@superboyiii Could you add your source? looks different as the first version

[shargon]

I'm using SmartContract.Framework 2.9.3.1, is it related to this issue?

I used the library inside the repository, not the nuget

[superboyiii]

Oh, Maybe that's the point. I use the nuget, maybe it's incompatible.

[shargon]

@superboyiii this is the issue

The new version use this syscall

neo-devpack-dotnet/src/Neo.SmartContract.Framework/Services/Neo/Runtime.cs

Line 7 in f461e54

[Syscall("System.Runtime.GetTrigger")]

And the nuget version use this

neo-devpack-dotnet/Neo.SmartContract.Framework/Services/Neo/Runtime.cs

Line 7 in 5edcebe

[Syscall("Neo.Runtime.GetTrigger")]

So you need to use the library from the bin folder, until we release a nuget for 3x (wait for #106)

[superboyiii]

All right. Let me try it again.

[shargon]

Also I added here neo-project/neo-node@2360e7a some checks in order to prevent this issues in the future.

[superboyiii]

Also I added here neo-project/neo-cli@2360e7a some checks in order to prevent this issues in the future.

@shargon Good job! Thanks for your suggestion, mine works well now.

[shargon]

Thanks you!

[shargon]

Ping @lightszero