Remove Runtime.Notify

[cschuchardt88]

You should just remove Runtime.Notify its useless now. Or have it add the name to contract manifest.

Get error Inner InvalidOperationException: Event 'SayHello3' does not exist.

Contract

public class EventContract : SmartContract
{
    public delegate void OnSayHelloDelegate(string message);

    [DisplayName("SayHello1")]
    public static event OnSayHelloDelegate OnSayHello;

    [DisplayName("SayHello2")]
    public static event Action<string> SayHello;

    public static void Main()
    {
        OnSayHello("Hello, alice");

        SayHello("Hello, bob");

        Runtime.Notify("SayHello3", new[] { "Hello, joe" }); // crash
    }
}

[vncoelho]

Perhaps that is right to do

[Jim8y]

@shargon how do you think? I think this is a bug maybe, i have asked Erik for his opinion, but get no response.
maybe we should vote to make a decision? @vncoelho @roman-khimov

[cschuchardt88]

@Jim8y Its not a bug. Remember when a patch came out it allowed contracts to ONLY emit a notify/event if it exists in the contract manifest.

[Jim8y]

Now updated the contract analyzer #839 to check the notify name with id NC4019

[cschuchardt88]

What if i did or want to do:

public static void SayHelloTo(string eventName, string name)
{
    Runtime.Notify(eventName, new[] { $"Hello, {name}" });
}

Also what about the parameters? Do you check though too against manifest?

[Jim8y]

can be added.

[shargon]

I think that is a bug, seems good

[cschuchardt88]

@Jim8y Why not have Runtime.Notify event name be added to the manifest if it doesn't exist in the contract? Because you have to compile the contract in order to deploy or update.

[roman-khimov]

Runtime.Notify event name be added to the manifest if it doesn't exist in the contract?

You can't do it for every possible Runtime.Notify() invocation, that's exactly your example with Runtime.Notify(someVar, ...). If event name is a constant and if you exactly know all types of all parameters, that can be done (like in nspcc-dev/neo-go#3008 with --guess-eventtypes), but not in general case. So requiring event specification of some kind (https://docs.neo.org/docs/en-us/develop/write/basics.html#events is C# probably) is perfectly fine and since this example is about event, it should just have one.

[Jim8y]

@shargon @roman-khimov , lets vote whether we ban Notify from contract developer. I think it is uselss now without allowing arbitary notification as user can use event directly.

[roman-khimov]

You can't ban Notify! How would you make a NEP-17 contract without it?

[Jim8y]

then any idea of solving the issue that notify become a trap now?