Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emotion typings #1983

Open
spencercorwin opened this issue Feb 26, 2020 · 1 comment
Open

Fix emotion typings #1983

spencercorwin opened this issue Feb 26, 2020 · 1 comment
Labels
area/website Categorize issue or PR as website (@neo-one/website) related good first issue kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed.

Comments

@spencercorwin
Copy link
Collaborator

Description

In my PR to upgrade TS to v3.8.1-rc here I had to add a whole lot of any types and other generic generic types (<{}, {}>), mostly to the styled() method from emotion. This was due to some obscure and very difficult to fix types that emotion was/is looking for. At some point this needs to be fixed and the type-safety added back. It looks like emotion has already acknowledged the problem and merged a fix here. But it seems it won't be released until emotion v11. See here. It's hard to tell when this will be released. I tried using @emotion/styled v11.0.0-next.11 without success. So perhaps the fix didn't make it into that specific version? Or perhaps there's a solution mentioned here? In any case, this should be fixed when possible. It should be easy to revert my temporary fix by git revert-ing this commit here.

Steps to Reproduce

  1. Open repo
  2. Revert commit mentioned
  3. rush tsc

Expected behavior: No type errors

Actual behavior: Lots of type errors

Reproduces how often: 100%

Versions

On master without the type fix mentioned above.

Additional Information

None.

@spencercorwin spencercorwin added area/website Categorize issue or PR as website (@neo-one/website) related kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed. labels Feb 26, 2020
@spencercorwin
Copy link
Collaborator Author

emotion-js/emotion#1606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website Categorize issue or PR as website (@neo-one/website) related good first issue kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed.
Projects
None yet
Development

No branches or pull requests

1 participant