Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused arguments #97

Merged
merged 2 commits into from
Nov 7, 2017
Merged

Fix unused arguments #97

merged 2 commits into from
Nov 7, 2017

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Nov 7, 2017 •
edited
Loading

Motivation and context:
Fixes unused arguments reported in #94.

  1. Removed the argument in ConstructionContext as it is not used at all anymore.
  2. Properly pass on intercept_width in IA.

Interactions with other PRs:
none

How has this been tested?
existing tests

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • [n/a] I have updated the documentation accordingly.
  • I have included a changelog entry.
  • [n/a] I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

Still to do:

@jgosmann jgosmann added this to the 0.3.1 release milestone Nov 7, 2017
@jgosmann jgosmann self-assigned this Nov 7, 2017
@jgosmann jgosmann removed their assignment Nov 7, 2017
@jgosmann jgosmann requested a review from Seanny123 November 7, 2017 22:01
@jgosmann jgosmann merged commit b3a27ee into master Nov 7, 2017
@jgosmann jgosmann deleted the unused-args branch November 7, 2017 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seanny123 Seanny123 Seanny123 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.3.1 release
Development

Successfully merging this pull request may close these issues.
2 participants
@jgosmann @Seanny123