Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in tests. #90

Merged
merged 2 commits into from
Nov 4, 2017
Merged

Fix warnings in tests. #90

merged 2 commits into from
Nov 4, 2017

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Nov 3, 2017 •
edited
Loading

Motivation and context:
Fix relevant warnings and hide irrelevant warnings to have less noise and make future relevant warnings more salient.

Interactions with other PRs:
none

How has this been tested?
ran the tests

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • [n/a] I have updated the documentation accordingly.
  • I have included a changelog entry.
  • [n/a] I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@jgosmann jgosmann added this to the 0.3.1 release milestone Nov 3, 2017
@jgosmann jgosmann merged commit 57c1103 into master Nov 4, 2017
@jgosmann jgosmann deleted the warnings branch November 4, 2017 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seanny123 Seanny123 Seanny123 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.3.1 release
Development

Successfully merging this pull request may close these issues.
2 participants
@jgosmann @Seanny123