Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to create inhibition node. #65

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Add function to create inhibition node. #65

merged 1 commit into from
Jul 18, 2017

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Jul 10, 2017 •
edited
Loading

Motivation and context:

This makes it easier to inhibit complete networks, especially those with a lot of ensembles like spa.State.

Interactions with other PRs:
none, though this is based on nengo/nengo#1288.

How has this been tested?

Added a test.

How long should this take to review?

  • Average (neither quick nor lengthy)

Where should a reviewer start?

Types of changes:

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jgosmann jgosmann added this to the 0.3 release milestone Jul 10, 2017
@jgosmann
Add function to create inhibition node.
c84d919 
Useful to inhibit complete networks.

Closes #26.
@jgosmann jgosmann merged commit 4a87ade into master Jul 18, 2017
@jgosmann jgosmann deleted the inhibition branch July 18, 2017 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seanny123 Seanny123 Seanny123 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.3 release
Development

Successfully merging this pull request may close these issues.
2 participants
@jgosmann @Seanny123