Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
This PR makes a couple of improvements to the vocabulary translation mechanism.
populate=False
. This fixes Add argument to ignore missing keys in translate #56.To make it possible to use the solver argument in action rules, I imported the whole nengo name space into the action rule built-ins. But it occured to me that this cannot be the final solution because solvers might be defined outside of nengo and these solvers should be usable to. However, making all globals accessible is also problematic because names can refer to modules or semantic pointers and at parse time this can currently not be determined (technically it should be possible, but will require some major changes to the parsing). Maybe the best option is to have the user explicitely populate the builtin namespace, but this will increase boiler plate code.
Interactions with other PRs:
none
How has this been tested?
added tests
How long should this take to review?
Where should a reviewer start?
Might make sense to do this one in order of the commits.
Types of changes:
Checklist:
Still to do: