Drop Python 3.5 support #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgosmann
changed the title
jgosmann
force-pushed
the
drop-py35
branch
3 times, most recently
from
d75d1fa to
8658064
Compare
Seanny123
approved these changes
Dec 1, 2020
hunse
reviewed
Dec 2, 2020
.nengobones.yml
Outdated
|
|
||
| travis_yml: | ||
| python: 3.7 | ||
| python: 3.9 |
There was a problem hiding this comment.
We don't officially support Python 3.9 yet in Nengo, though that's not to say it might not all work fine.
There was a problem hiding this comment.
Unofficially, I'm currently using Python 3.9, but with 3.8 the issue was Windows specific so who knows.
There was a problem hiding this comment.
I think it doesn't hurt to run the tests on 3.9 too as long as they pass. I also think that the "Python 3.6+" formulation in the the readme is fine (NengoSPA is more platform independent than Nengo, so it is even more unlikely that a new Python release breaks things). Might consider taking the classifier out of the setup.py ... but that I would have to re-add it later.
hunse
approved these changes
Dec 2, 2020
jgosmann
force-pushed
the
drop-py35
branch
2 times, most recently
from
b808459 to
0d30ac7
Compare
This drops Python 3.5 and adds Python 3.8, 3.9 Note that the build of the docs stalls with the 'xenial' dist, thus using 'focal' (the most recent dist) instead.
A few places remain string format calls because either an f-string cannot be used or would be less legible. All string interpolations should be gone now. In two instances the interpolation argument was missing which is now fixed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
Drop support for Python 3.5 because nengo-bones does not work with it anymore.
format()calls to f-strings which were introduced with Python 3.6. A fewformat()calls remain where an f-string either cannot be used or would be less legible.Interactions with other PRs:
Fixes build for all other PRs. Other PRs should switch over to f-strings.
How has this been tested?
existing tests
How long should this take to review?
Where should a reviewer start?
Changes to the .nengobones.yml might be a good place?
Types of changes:
Checklist:
Still to do: