Fix precedence with PointerSymbols #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgosmann
force-pushed
the
fix-pointersym-precedence
branch
from
86a98d8 to
7627ee3
Compare
This will allow correct handling of operator precedence for PointerSymbol and might also be used to reduce the amount of parenthesis in automatically generated SemanticPointer names.
This enables correct handling of precedence, e.g. s = sym.A + sym.B s * sym.C will be correctly handled as (sym.A + sym.B) * sym.C instead of sym.A + (sym.B * sym.C). Fixes #267.
jgosmann
force-pushed
the
fix-pointersym-precedence
branch
from
7627ee3 to
4a716eb
Compare
jgosmann
force-pushed
the
fix-pointersym-precedence
branch
from
4a716eb to
bd765b9
Compare
Seanny123
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
PointerSymbolwasn't handling precedence correctly, i.e.(sym.A + sym.B) * sym.Cwould evaluate tosym.A + (sym.B * sym.C). This PR changesPointerSymbolto keep track of the full syntax tree to handle the precedence correctly. The class to construct this syntax tree is fairly general and covers also some operators not in use by NengoSPA currently, but this allows to reuse it more easily or implement additionalPointerSymboloperators without changes to the syntax tree implementation. I intend to reuse that implementation to also provide betterSemanticPointerNames with fewer parenthesis, but this will be a separate PR.Changes to
PointerSymbolhave been done in a backwards compatible manner with regard to the public interface.Fixes #267.
Interactions with other PRs:
none
How has this been tested?
How long should this take to review?
Where should a reviewer start?
Types of changes:
Checklist: