Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure free floating connections are cleared #231

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Jun 20, 2019

Motivation and context:
Ensure free floating connections are cleared after leaving ActionSelection block.

Fixes #230.

Interactions with other PRs:
none

How has this been tested?
added a unit test

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@jgosmann jgosmann added this to the 0.6.2 milestone Jun 20, 2019
@jgosmann jgosmann requested review from Seanny123 and tcstewar June 20, 2019 17:53
@jgosmann jgosmann self-assigned this Jun 20, 2019
@jgosmann jgosmann force-pushed the bugfix/230/actionsel-cleanup branch from 41ca937 to 686720f Compare June 20, 2019 17:55
@jgosmann jgosmann force-pushed the bugfix/230/actionsel-cleanup branch from 686720f to 892f3df Compare June 20, 2019 18:25
after leaving ActionSelection block.

Fixes #230.
@jgosmann jgosmann force-pushed the bugfix/230/actionsel-cleanup branch from 892f3df to e5a5a73 Compare June 20, 2019 19:59
@jgosmann jgosmann merged commit 730ce0f into master Jun 21, 2019
@jgosmann jgosmann deleted the bugfix/230/actionsel-cleanup branch June 21, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ActionSelection does not clean up after exception handling
2 participants