Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing for special Semantic Pointers. #195

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Add parsing for special Semantic Pointers. #195

merged 1 commit into from
Jul 11, 2018

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Jul 6, 2018

Motivation and context:
Addresses #176.

Allows spa.sym.Zero, vocab['Identity'], and vocab.parse('AbsorbingElement') to access special Semantic Pointers. These names won't be listed in vocab.keys() or vocab.vectors.

Interactions with other PRs:
none

How has this been tested?
added a test

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@jgosmann jgosmann added this to the 0.6 milestone Jul 6, 2018
@jgosmann jgosmann requested review from Seanny123 and tcstewar July 6, 2018 19:42
@jgosmann jgosmann self-assigned this Jul 6, 2018
@Seanny123
Copy link
Collaborator

Still lookin' good.

@jgosmann jgosmann merged commit c322ac1 into master Jul 11, 2018
@jgosmann jgosmann deleted the se-sym branch July 11, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants