Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce mapping argument on associative memories #177

Merged
merged 2 commits into from
Jul 6, 2018

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Jun 6, 2018

Motivation and context:
As discussed here this makes the mapping argument for associative memories required. This makes explicit which vectors are cleaned up and should lead to less surprise that vectors added later to a vocabulary are not included. It also ensures that in the GUI the vectors are added to the vocabulary instead of potentially creating an empty cleanup memory.

Furthermore, as syntactic sugar sequences of strings are allowed as syntactic sugar for {k: k for k in sequence}.

Interactions with other PRs:
based on #171 (that one provides pure bugfixes, this one provides API changes which require a minor release instead of a bugfix release)

How has this been tested?
added tests

How long should this take to review?

  • Average (neither quick nor lengthy)

Types of changes:

  • Breaking change (fix or feature that causes existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@jgosmann jgosmann added this to the 0.6 milestone Jun 6, 2018
@jgosmann jgosmann requested a review from Seanny123 June 6, 2018 20:30
@jgosmann jgosmann force-pushed the assoc-require-mapping branch from ede63c4 to 5c66e78 Compare July 6, 2018 19:04
@jgosmann jgosmann removed their assignment Jul 6, 2018
@jgosmann jgosmann merged commit 8981d0d into master Jul 6, 2018
@jgosmann jgosmann deleted the assoc-require-mapping branch July 6, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants