Enforce mapping argument on associative memories #177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
As discussed here this makes the
mapping
argument for associative memories required. This makes explicit which vectors are cleaned up and should lead to less surprise that vectors added later to a vocabulary are not included. It also ensures that in the GUI the vectors are added to the vocabulary instead of potentially creating an empty cleanup memory.Furthermore, as syntactic sugar sequences of strings are allowed as syntactic sugar for
{k: k for k in sequence}
.Interactions with other PRs:
based on #171 (that one provides pure bugfixes, this one provides API changes which require a minor release instead of a bugfix release)
How has this been tested?
added tests
How long should this take to review?
Types of changes:
Checklist: