Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying directives at tag level generates excessive digests #85

Open
jaredjensen opened this issue May 5, 2017 · 0 comments
Open

Applying directives at tag level generates excessive digests #85

jaredjensen opened this issue May 5, 2017 · 0 comments

Comments

@jaredjensen
Copy link

jaredjensen commented May 5, 2017

I've been troubleshooting a performance issue in a client's application that uses this library. The app generates a large number of form field, each implemented as a directive with conditional template. I've determined that each validation directive defined in customValidationTypes.js results in a digest cycle, even if the app's template is simply <input>. So if there are 16 out-of-box validations, I get 16 digest cycles for that one input field. This is resulting in ~10,000 digest cycles to load the page.

This makes sense given the validation directives appear to be created at the tag level, so they're linked whether used or not. Is this the intended design or am I misunderstanding how the library is used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant