-
-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install & run PHP-CS-Fixer #2250
Conversation
ab6ab11
to
81fe17d
Compare
I also think that we should remove StyleCI in favor of a PHP-CS-Fixer job. I would have to message/email @GuilhemN though asking if he can disable StyleCI for this project before merging this. As far as I can see there is no easy way to disable it using a simple config change in
I think running it on the latest PHP version (8.3) will suffice. |
I've refactored the current CI workflow a bit and introduced a composite action that allows to re-use the steps for setting up and installing the Composer dependencies across multiple jobs. This change should make it quite easy to add a PHPStan CI job in #2249 as well 😄 |
Update: I have sent an email to @GuilhemN asking to disable StyleCI for this repo |
StyleCI has now been disabled, I will apply my own suggestion and merge it asap |
Thank you very much @DominicLuidold for your work ❤️ |
As there are currently efforts to introduce PHPStan (see #2249), I thought of also introducing PHP-CS-Fixer as a dev dependency (to additionally improve the code quality) and using/upgrading the existing config file.
Already done:
PHP-CS-Fixer
as a dev dependencyPossible further steps as part of this PR that need to be discussed:
CI
/continuous-integration
workflow (to have a single source of truth regarding code style)?Footnotes
This approach will not work on PHP 7.4 and PHP 8.0 as some files already use newer syntax leading to failures in these jobs. ↩