Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align runner.os / runner.arch to known values #1510

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Dec 14, 2022

This change now also unifies RUNNER_OS with runner.os, I suggest to do the same thing for the github context.

This is a breaking change for github-act-runner, but we should align to actions/runner where possible

Fixes #1509

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.02s
✅ REPOSITORY gitleaks yes no 2.48s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.98s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@ChristopherHX ChristopherHX marked this pull request as ready for review December 14, 2022 19:30
@ChristopherHX ChristopherHX requested a review from a team as a code owner December 14, 2022 19:30
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #1510 (0545c82) into master (4f8da0a) will increase coverage by 3.71%.
The diff coverage is 67.39%.

@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
+ Coverage   57.50%   61.22%   +3.71%     
==========================================
  Files          32       46      +14     
  Lines        4594     7141    +2547     
==========================================
+ Hits         2642     4372    +1730     
- Misses       1729     2462     +733     
- Partials      223      307      +84     
Impacted Files Coverage Δ
pkg/common/file.go 0.00% <0.00%> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/container/parse_env_file.go 0.00% <0.00%> (ø)
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 13.58% <11.48%> (+8.04%) ⬆️
pkg/model/workflow.go 42.11% <18.51%> (-8.80%) ⬇️
...ontainer/linux_container_environment_extensions.go 24.32% <24.32%> (ø)
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify
Copy link
Contributor

mergify bot commented Dec 19, 2022

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added needs-work Extra attention is needed and removed needs-work Extra attention is needed labels Dec 19, 2022
@mergify mergify bot merged commit 6ab71ec into master Dec 19, 2022
@mergify mergify bot deleted the map-runnerctx-to-dotnet-actions branch December 19, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUNNER_OS should return macOS instead of darwin and wrong RUNNER_ARCH on MacOS M1
3 participants